Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wifi: rtw89: use readable return 0 in
 rtw89_mac_cfg_ppdu_status()
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20230213091328.25481-1-pkshih@realtek.com>
References: <20230213091328.25481-1-pkshih@realtek.com>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     <error27@gmail.com>, <linux-wireless@vger.kernel.org>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <167644746638.2758.1702991891864476396.kvalo@kernel.org>
Date:   Wed, 15 Feb 2023 07:51:07 +0000 (UTC)
Precedence: bulk

Ping-Ke Shih <pkshih@realtek.com> wrote:

> For normal (successful) flow, it must return 0. The original code uses
> 'return ret', and then we need to backward reference to initial value to
> know 'ret = 0'. Changing them to 'return 0', because it will be more
> readable and intuitive. This patch doesn't change logic at all.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/r/202302101023.ctlih5q0-lkp@intel.com/
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-next.git, thanks.

210871887208 wifi: rtw89: use readable return 0 in rtw89_mac_cfg_ppdu_status()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230213091328.25481-1-pkshih@realtek.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches