From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] wifi: wfx: Remove some dead code
Date:   Wed, 15 Feb 2023 14:23:56 +0100
Message-ID: <5176724.BZd2XUeKfp@pc-42>
Organization: Silicon Labs
In-Reply-To: <809c4a645c8d1306c0d256345515865c40ec731c.1676464422.git.christophe.jaillet@wanadoo.fr>
References: <809c4a645c8d1306c0d256345515865c40ec731c.1676464422.git.christophe.jaillet@wanadoo.fr>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?qijHo0vpbB+kYZy1OoFGEopKfwQUN5VVlI6JWf/Mdc9XsCKNn64Xt6m3uN?=
 =?iso-8859-1?Q?h116YqKpmN4oJkJoGoWqvhr/I8d4tEHb06Plk5ioV9tX0yfq3MYAPXQh1G?=
 =?iso-8859-1?Q?YvV2BDvq+lWpEmRh3jDSJxiZcjRCcdAwO9D6gJBlDgX1lWkRImYA7MDwOW?=
 =?iso-8859-1?Q?4b9Nz53Qtcwzz8T+EWKM69j/ZCW6cWxXXhIOeKInXXqiSAdwfRRdy9DlkF?=
 =?iso-8859-1?Q?VXp4vEMd5hQR+PL5kw6KgdVFI6lLpw/BpZ2hFlkg/wUvWMOTfE0+kmHlJV?=
 =?iso-8859-1?Q?2mc0VxsHcC0Bxi/Ylv/bPaomVixlvrmU7WS6x0gHqXl5IjcbKlEOLz5tuW?=
 =?iso-8859-1?Q?PjLiYJGOamB68eUVjF2OO+J7ZMnwviyAvt0Z6if1cmQr4y9aZ742icMip5?=
 =?iso-8859-1?Q?rKjLX+5hc30WRzx4LMHxmZn9MZrJp+95QwEeZ6JElOfodbibQjup2gUtzS?=
 =?iso-8859-1?Q?w9QFEP945zOucpoPrwC0e2S+0lPyMC2mD9LsyDbcqziuI/JRDX+NTsfMI7?=
 =?iso-8859-1?Q?FOBN9qIEN+r3mJ8tYQ5RCMp/VxdKHTB3b0pDWKB+twkgPQpN0gkFkfmKP5?=
 =?iso-8859-1?Q?6vxDVcdKeKealiX9ylrredSSWq66FJON3OPK5YgAbot15SrU64AwTHHsj7?=
 =?iso-8859-1?Q?OmOmyCG0Z4mJtx2NwkPu1OyglDlSfJqlTPUTNipUvDFdkfpPr4Lbj/isJm?=
 =?iso-8859-1?Q?8lw9c82knegKfDpLRRergJI4F/KYAhI6FoRaPgeTN+V2W/5+GhmRJJ1pJY?=
 =?iso-8859-1?Q?h6x11tBVXxXozkEfhVjJE1jD34LlkHR6iS9BMfvjHB3cssq3Dz41Bxzh7K?=
 =?iso-8859-1?Q?ENq7mvLAoR4MpH52W98yRzc7SFFiFO/Ol9fY5Is+eSgxnGfr3h+qxjvVTz?=
 =?iso-8859-1?Q?cd0h/Zz3ibzFqzRsMqzxmcfwHvB4NS/bV6c64fuN+yfCXVoM/MtuGt4d8E?=
 =?iso-8859-1?Q?fEWn5gxgYnLEeZiZt2p+4JjBa8pf7l25Z89z4KWCSTgnIVKKzB1snMuvho?=
 =?iso-8859-1?Q?KmfyKAeyzz7jMYA3+o4PvGnnl3gmut2qR8v8Z/umI3k4AqUis4GggBYm5q?=
 =?iso-8859-1?Q?NDrYuw/S1uxzWr9M17kDLfGPZstaeQysRyhn1ApODkP9rk30VvH7oXMxX+?=
 =?iso-8859-1?Q?A6Z8g13OW1EmyjSRr3hB0EIzjD/7q/eKk8D1+riAr3RFur4UeGsQ8R/xlk?=
 =?iso-8859-1?Q?3nKvlBsqoBdecbYC1Xv+w3UR4HACjGbk3D4ASmhPkNLXkaeXQMO/JjJMMi?=
 =?iso-8859-1?Q?RlADyVsS5OCcShA9PEZFk/yj7UUCLbL2d+EUMQOfjKSFIqUMPS0jF+8SgQ?=
 =?iso-8859-1?Q?0S8mBI2umbZD/maLY7twqzuZ+KYxyV7zCUOvY/P/HSMNTZaSasaBJIR3Ur?=
 =?iso-8859-1?Q?lCFkqjGfsZHCMv4ca/OoZx5HiW7y6jIMfCDcMRzkCmFN0QlEiDCUMe+ye+?=
 =?iso-8859-1?Q?PiZtnUoICY/eE3LM1NO2FMRL3TarLBA/Mm1P7pbU04zqDONDY8rqdKIoWH?=
 =?iso-8859-1?Q?OKcOnlelQzUyPm/HaKuR8AJDQrtfqhNdZwSNRypRXsxVfJSnF40E41qd5c?=
 =?iso-8859-1?Q?xmXON5UxGuj59ceVR15Je7jYOjwF7bg4aJ1cWdOqo3zRysMxqiGsjm5UAK?=
 =?iso-8859-1?Q?f2oAgaqFTVPpsRKhYBF7I7MbTruVaQ9mqw?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9781838d-8510-4950-2dda-08db0f57e839
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB6038.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 13:24:04.0532
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1jy/A/xZcpT1hCU9qPzkKIGwjcsHjJ155QpCtdeeGw9uZiCAKeABhDsL0/OLepCfg14oJWGOaG4WLRhGxBBjLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB7156
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hello Christophe,

On Wednesday 15 February 2023 13:34:37 CET Christophe JAILLET wrote:
>=20
> wait_for_completion_timeout() can not return a <0 value.
> So simplify the logic and remove dead code.
>=20
> -ERESTARTSYS can not be returned by do_wait_for_common() for tasks with
> TASK_UNINTERRUPTIBLE, which is the case for wait_for_completion_timeout()
>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/net/wireless/silabs/wfx/main.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/net/wireless/silabs/wfx/main.c b/drivers/net/wireles=
s/silabs/wfx/main.c
> index 6b9864e478ac..0b50f7058bbb 100644
> --- a/drivers/net/wireless/silabs/wfx/main.c
> +++ b/drivers/net/wireless/silabs/wfx/main.c
> @@ -358,13 +358,9 @@ int wfx_probe(struct wfx_dev *wdev)
>=20
>         wfx_bh_poll_irq(wdev);
>         err =3D wait_for_completion_timeout(&wdev->firmware_ready, 1 * HZ=
);
> -       if (err <=3D 0) {
> -               if (err =3D=3D 0) {
> -                       dev_err(wdev->dev, "timeout while waiting for sta=
rtup indication\n");
> -                       err =3D -ETIMEDOUT;
> -               } else if (err =3D=3D -ERESTARTSYS) {
> -                       dev_info(wdev->dev, "probe interrupted by user\n"=
);

This code is ran during modprobe/insmod. We would like to allow the user
to interrupt (Ctrl+C) the probing if something is going wrong with the
device.

So, the real issue is wait_for_completion_interruptible_timeout() should
be used instead of wait_for_completion_timeout().

(By reading this code again, it also seems the test "if (err <=3D 0)" is
useless)


--=20
J=E9r=F4me Pouiller