Message-ID: <554bb44c-f370-3729-aeb2-c77db7e63173@quicinc.com>
Date:   Thu, 16 Feb 2023 12:09:22 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH 3/7] mac80211: add combined power type definition for 6
 GHz
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>,
        <linux-wireless@vger.kernel.org>
References: <20220704102341.5692-1-quic_adisi@quicinc.com>
 <20220704102341.5692-4-quic_adisi@quicinc.com>
 <52e4bd3a7d24fca06a507f86fe23d23a552c7c2d.camel@sipsolutions.net>
From:   Aditya Kumar Singh <quic_adisi@quicinc.com>
In-Reply-To: <52e4bd3a7d24fca06a507f86fe23d23a552c7c2d.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/6/2022 16:31, Johannes Berg wrote:
> On Mon, 2022-07-04 at 15:53 +0530, Aditya Kumar Singh wrote:
>>
>> +/**
>> + * enum nl80211_regulatory_power_modes - 6 GHz regulatory power
>> + *					 modes
>> + * @NL80211_REG_AP_LPI: Low Power Indoor (Access Point)
>> + * @NL80211_REG_AP_SP: Standard Power (Access Point)
>> + * @NL80211_REG_AP_VLP: Very Low Power (Access Point)
>> + * @NL80211_REG_REGULAR_CLIENT_LPI: Low Power Indoor (Regular
>> + *				    or Default Client)
> 
> REG_REGULAR reads a bit weird, and anyway "REG" as the prefix for
> "regulatory_power_mode" is a bit strange?
> 
> Maybe use something like REG_PWR_MODE_... ?
Sure will use. Thanks for the suggestion.


> 
>> +++ b/net/wireless/util.c
>> @@ -190,6 +190,66 @@ struct ieee80211_channel *ieee80211_get_channel_khz(struct wiphy *wiphy,
>>   }
>>   EXPORT_SYMBOL(ieee80211_get_channel_khz);
>>   
>> +enum nl80211_regulatory_power_modes
>> +ieee80211_ap_reg_power_to_reg_power_mode(enum ieee80211_ap_reg_power ap_type)
>> +{
>> +	switch (ap_type) {
>> +	case IEEE80211_REG_LPI_AP:
>> +		return NL80211_REG_AP_LPI;
>> +	case IEEE80211_REG_SP_AP:
>> +		return NL80211_REG_AP_SP;
>> +	case IEEE80211_REG_VLP_AP:
>> +		return NL80211_REG_AP_VLP;
>> +	default:
>> +		return NL80211_REG_MAX_POWER_MODES + 1;
>> +	}
>> +}
>> +EXPORT_SYMBOL(ieee80211_ap_reg_power_to_reg_power_mode);
> 
> What is the use of that, why export it? Same for the other function.
We have two enum - one defined in ieee80211 header file having
two separate enum of AP and client power modes respectively and one in 
nl80211 header which is combined power type. At times there can be 
use-case to convert from enum in ieee80211 to nl80211. These helper
function will do that.

And in kernel layer whenever we need we can call these function. But if 
driver needs to call it, at that point we need these functions to be 
exported (called from different kernel module).

> 
> johannes