Message-ID: <b895583b-7637-9025-d028-efbbc663e139@quicinc.com>
Date:   Thu, 16 Feb 2023 15:03:03 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH 6/7] cfg80211: rework nl80211_parse_chandef for 6 GHz
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>,
        <linux-wireless@vger.kernel.org>
References: <20220704102341.5692-1-quic_adisi@quicinc.com>
 <20220704102341.5692-7-quic_adisi@quicinc.com>
 <0ed850ac7d13fc5d40545aff1d59d710374bfcf4.camel@sipsolutions.net>
From:   Aditya Kumar Singh <quic_adisi@quicinc.com>
In-Reply-To: <0ed850ac7d13fc5d40545aff1d59d710374bfcf4.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/18/2023 16:33, Johannes Berg wrote:
> On Mon, 2022-07-04 at 15:53 +0530, Aditya Kumar Singh wrote:
>>
>> +	/* For APs, 6 GHz power mode is taken from the user configured
>> +	 * value. However, for clients, power mode is also dependent
>> +	 * upon the APs power mode to which this client has associated.
>> +	 * Hence for client, need to take power mode of asscoiated AP,
> 
> 
> typo - associated
Sure will rectify. Thanks for pointing it out.

> 
> But anyway, were you going to resubmit this with comments from the first
> patches addressed?
Yes! Working on addressing the review comments. Will send next version.

> Honestly I'd also like to see a bit more discussion (in the cover letter
> I guess) about the solution with "multiple channel spaces" and all that.
> And ideally about alternatives considered - why not for example keep a
> single space with flags indicating support for the power mode, etc.
Sure will include these in the cover letter.

> 
> johannes