Message-ID: <615fc28f-5997-4a85-8fcf-ffccdfa4cc3f@gmail.com>
Date:   Thu, 16 Feb 2023 16:12:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH] wifi: rtl8xxxu: 8188e: parse single one element of RA
 report for station mode
Content-Language: en-US
To:     Ping-Ke Shih <pkshih@realtek.com>, Jes.Sorensen@gmail.com,
        kvalo@kernel.org
Cc:     error27@gmail.com, linux-wireless@vger.kernel.org
References: <20230216004654.4642-1-pkshih@realtek.com>
From:   Bitterblue Smith <rtl8821cerfe2@gmail.com>
In-Reply-To: <20230216004654.4642-1-pkshih@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 16/02/2023 02:46, Ping-Ke Shih wrote:
> Intentionally parsing single one element of RA report by breaking loop
> causes a smatch warning:
>   drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188e.c:1678 rtl8188e_handle_ra_tx_report2() warn:
>   ignoring unreachable code.
> 
> With existing comments, it intends to process single one element for
> station mode, but it will parse more elements in AP mode if it's
> implemented. Implement program logic according to existing comment to avoid
> smatch warning, and also be usable for both AP and stations modes.
> 
> Compile test only.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/r/202302142135.LCqUTVGY-lkp@intel.com/
> Cc: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
>  .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188e.c   | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188e.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188e.c
> index a99ddb41cd244..f15b099899e5c 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188e.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188e.c
> @@ -1699,6 +1699,12 @@ void rtl8188e_handle_ra_tx_report2(struct rtl8xxxu_priv *priv, struct sk_buff *s
>  
>  	dev_dbg(dev, "%s: len: %d items: %d\n", __func__, tx_rpt_len, items);
>  
> +	/* We only use macid 0, so only the first item is relevant.
> +	 * AP mode will use more of them if it's ever implemented.
> +	 */
> +	if (!priv->vif || priv->vif->type == NL80211_IFTYPE_STATION)
> +		items = 1;
> +
>  	for (macid = 0; macid < items; macid++) {
>  		valid = false;
>  
> @@ -1741,12 +1747,6 @@ void rtl8188e_handle_ra_tx_report2(struct rtl8xxxu_priv *priv, struct sk_buff *s
>  			min_rpt_time = ra->rpt_time;
>  
>  		rpt += TX_RPT2_ITEM_SIZE;
> -
> -		/*
> -		 * We only use macid 0, so only the first item is relevant.
> -		 * AP mode will use more of them if it's ever implemented.
> -		 */
> -		break;
>  	}
>  
>  	if (min_rpt_time != ra->pre_min_rpt_time) {

Tested-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>