Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-156-g081acc5ed5-fm-20230206.001-g081acc5e
Mime-Version: 1.0
Message-Id: <a6f0f854-6ee2-4535-825a-b967e37ea221@app.fastmail.com>
In-Reply-To: <4e88fae65e85366bfc5d728c0e4c47133c7b9523.camel@realtek.com>
References: <20230217095910.2480356-1-arnd@kernel.org>
 <4e88fae65e85366bfc5d728c0e4c47133c7b9523.camel@realtek.com>
Date:   Fri, 17 Feb 2023 13:17:59 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Ping-Ke Shih" <pkshih@realtek.com>,
        "Arnd Bergmann" <arnd@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        "Kalle Valo" <kvalo@kernel.org>,
        "Jes.Sorensen@gmail.com" <Jes.Sorensen@gmail.com>,
        "rtl8821cerfe2@gmail.com" <rtl8821cerfe2@gmail.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>,
        "Eric Dumazet" <edumazet@google.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Netdev <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: rtl8xxxu: add LEDS_CLASS dependency
Content-Type: text/plain
Precedence: bulk

On Fri, Feb 17, 2023, at 12:50, Ping-Ke Shih wrote:
> On Fri, 2023-02-17 at 10:59 +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
>> b/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
>> index 091d3ad98093..2eed20b0988c 100644
>> --- a/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/Kconfig
>> @@ -5,6 +5,7 @@
>>  config RTL8XXXU
>>         tristate "Realtek 802.11n USB wireless chips support"
>>         depends on MAC80211 && USB
>> +       depends on LEDS_CLASS
>
> With 'depends on', this item will disappear if LEDS_CLASS isn't selected.
> Would it use 'select' instead?

In general, 'select' is for hidden symbols, not user visible ones.
The main problem is mixing 'select' and 'depends on', as this
leads to circular dependencies. With LEDS_CLASS there is unfortunately
already a mix of the two that can be hard to clean up, but
'depends on' is usually the safer bet to avoid causing more
problems.

For wireless drivers, you can also use MAC80211_LEDS to abstract
some of this, but that is probably a larger rework.


    Arnd