Message-ID: <16b0fcce-01ff-3d55-14ca-f088f53c8724@quicinc.com>
Date:   Tue, 21 Feb 2023 16:43:42 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH 2/2] mac80211: support RNR for EMA AP
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>,
        <linux-wireless@vger.kernel.org>
References: <20221114230416.20192-1-quic_alokad@quicinc.com>
 <20221114230416.20192-3-quic_alokad@quicinc.com>
 <d9461ebd1a17608f73ef832c60fa7489e358a84e.camel@sipsolutions.net>
From:   Aloka Dixit <quic_alokad@quicinc.com>
In-Reply-To: <d9461ebd1a17608f73ef832c60fa7489e358a84e.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/14/2023 8:03 PM, Johannes Berg wrote:
> On Mon, 2022-11-14 at 15:04 -0800, Aloka Dixit wrote:
>>
>>   	if (params->mbssid_ies) {
>>   		mbssid = params->mbssid_ies;
>>   		size += struct_size(new->mbssid_ies, elem, mbssid->cnt);
>> -		size += ieee80211_get_mbssid_beacon_len(mbssid, mbssid->cnt);
>> +		if (params->rnr_ies) {
>> +			rnr = params->rnr_ies;
>> +			size += struct_size(new->rnr_ies, elem, rnr->cnt);
>> +		}
> 
> Is this right? The struct_size() is only the size of the struct, but you
> need the size of the elements contained in it here, i.e. the sum of the
> .len fields?
> 
> johannes
> 

Yes, I modified ieee80211_get_mbssid_beacon_len() to include the 'len' 
fields if rnr_ies is present. It is called right after the lines you 
have copied here with the new input parameter.