Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFBBFC61DA3 for ; Wed, 22 Feb 2023 00:11:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229761AbjBVALI (ORCPT ); Tue, 21 Feb 2023 19:11:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbjBVALH (ORCPT ); Tue, 21 Feb 2023 19:11:07 -0500 Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5E512449D for ; Tue, 21 Feb 2023 16:11:01 -0800 (PST) X-Virus-Scanned: Proofpoint Essentials engine Received: from mail3.candelatech.com (mail2.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 13B634C0070 for ; Wed, 22 Feb 2023 00:11:00 +0000 (UTC) Received: from [192.168.1.115] (unknown [98.97.113.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 9EC2D13C2B0 for ; Tue, 21 Feb 2023 16:10:59 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 9EC2D13C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1677024659; bh=J036A/HP/UD8oICsPqZ/jUoJpWSJ2iHNntArjXNogWU=; h=To:From:Subject:Date:From; b=b2E9lQb2/YmnyIzsnoe8qWdbAEK5+DBrlnKAVDLVIuIdbwwYQHQiomPG3w7h/KGOz 333pnyGxSBiHe1C6r1jI8wK97Qr53ZmrYq/KThpYDo75vGrPYhpkggk0uyKpHQwVpT 5LKDRLUq/8I/YQw1iCtUW3/OsOfose7LbLOmbluQ= To: "linux-wireless@vger.kernel.org" From: Ben Greear Subject: Potential issue in ieee80211_rx_handlers_result related to link_sta? Organization: Candela Technologies Message-ID: <88c16925-225c-c68c-6121-c3a2c08535a0@candelatech.com> Date: Tue, 21 Feb 2023 16:10:58 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-MW Content-Transfer-Encoding: 7bit X-MDID: 1677024660-QUxlRFFacwsC X-MDID-O: us5;ut7;1677024660;QUxlRFFacwsC; Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org I'm working to rebase my patches on the 6.2 kernel. I am currently tracking down something I did that causes the code to crash in the code below right above 'fallthrough'. I'm wondering why it is checking for rx->sta but then access ing rx->link_sta? static void ieee80211_rx_handlers_result(struct ieee80211_rx_data *rx, ieee80211_rx_result res) { switch (res) { case RX_DROP_MONITOR: I802_DEBUG_INC(rx->sdata->local->rx_handlers_drop); if (rx->sta) rx->link_sta->rx_stats.dropped++; fallthrough; Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com