Message-ID: <934e866942bd8d413bbb4570741e5d8d1537f211.camel@sipsolutions.net>
Subject: Re: [PATCH 1/2] wifi: cfg80211: Add beacon hint notifier support
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Wen Gong <quic_wgong@quicinc.com>,
        "Youghandhar Chintala (Temp)" <quic_youghand@quicinc.com>,
        ath10k@lists.infradead.org
Cc:     linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
        quic_mpubbise@quicinc.com
Date:   Wed, 22 Feb 2023 09:00:59 +0100
In-Reply-To: <9ae693f2-b19e-ff1f-851c-c3d09db4d9d1@quicinc.com>
References: <20221222124221.30894-1-quic_youghand@quicinc.com>
         <20221222124221.30894-2-quic_youghand@quicinc.com>
         <1df59863e78e8ddbe7eb3a74e6dd4c8f0bd7f098.camel@sipsolutions.net>
         <96cab5d9-9090-4cb2-ff17-eadc9da12f50@quicinc.com>
         <0d4b99ab0a5bedc82f35bc1e548a611564b010e5.camel@sipsolutions.net>
         <9ae693f2-b19e-ff1f-851c-c3d09db4d9d1@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-02-22 at 08:22 +0800, Wen Gong wrote:
> On 2/15/2023 11:10 PM, Johannes Berg wrote:
> > > > Why is this even needed? You should always get reg_notifier after t=
his
> > > > anyway?
> > > Currently when channel flag changed through the beacon hints are not
> > > informed to driver.
> > >=20
> > > reg_notifier will be triggered for regdomain changes but not for chan=
nel flag changes due to beacon hints.
> > >=20
> > So maybe triggering reg notifier once would be sufficient, a la Wen's
> > patch that I recently merged?
>=20
> My patch only take effect for this flag, not for all wiphy.
>=20
> if (wiphy->flags & WIPHY_FLAG_NOTIFY_REGDOM_BY_DRIVER)
>=20
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit?id=
=3Dd99975c4953eb79e389d4630e848435c700e2dfc
>=20

Oh sure, I meant this patch could do something similar, instead of
introducing a new notifier callback.

johannes