Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wifi: rtl8xxxu: 8188e: parse single one element of RA
 report
 for station mode
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20230216004654.4642-1-pkshih@realtek.com>
References: <20230216004654.4642-1-pkshih@realtek.com>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     <Jes.Sorensen@gmail.com>, <rtl8821cerfe2@gmail.com>,
        <error27@gmail.com>, <linux-wireless@vger.kernel.org>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <167706896785.20055.7787168018772184989.kvalo@kernel.org>
Date:   Wed, 22 Feb 2023 12:29:32 +0000 (UTC)
Precedence: bulk

Ping-Ke Shih <pkshih@realtek.com> wrote:

> Intentionally parsing single one element of RA report by breaking loop
> causes a smatch warning:
>   drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188e.c:1678 rtl8188e_handle_ra_tx_report2() warn:
>   ignoring unreachable code.
> 
> With existing comments, it intends to process single one element for
> station mode, but it will parse more elements in AP mode if it's
> implemented. Implement program logic according to existing comment to avoid
> smatch warning, and also be usable for both AP and stations modes.
> 
> Compile test only.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/r/202302142135.LCqUTVGY-lkp@intel.com/
> Cc: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> Tested-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>

Patch applied to wireless-next.git, thanks.

398eb19415eb wifi: rtl8xxxu: 8188e: parse single one element of RA report for station mode

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230216004654.4642-1-pkshih@realtek.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches