Message-ID: <2564165999cf5319e58aa0898a2866612f8af293.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: wext: Eliminate log spamming in
 wireless_warn_cfg80211_wext()
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Larry Finger <Larry.Finger@lwfinger.net>,
        Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org
Date:   Thu, 23 Feb 2023 09:12:29 +0100
In-Reply-To: <20230222204945.6716-1-Larry.Finger@lwfinger.net>
References: <20230222204945.6716-1-Larry.Finger@lwfinger.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-02-22 at 14:49 -0600, Larry Finger wrote:
> Commit dc09766c755c {"wifi: wireless: warn on most wireless extension
> usage") introduces a warning when wireless extensions are used with
> cfg80211 drivers. Although such a warning is desirable, the current
> implementation overflows the dmesg buffer with thousands of warnings,
> all of which are the same.
>=20

What are you seeing them from?

This is rate-limited, so not sure why you're getting so many?

>  A WARN_ONCE() call is sufficient.

I think a WARN is inappropriate (it's a userspace 'issue', not an in-
kernel consistency problem), but I guess we could pr_once().

But that's not great because it only shows a single application that was
still using it, not if there are multiple.

Hmm. Not sure what to do. Let's start with "why are you getting it so
much". Maybe we can somehow print it less, or try to do per application
once, or something.

johannes