MIME-Version: 1.0
References: <CAEyMn7aV-B4OEhHR4Ad0LM3sKCz1-nDqSb9uZNmRWR-hMZ=z+A@mail.gmail.com>
 <e027bfcf-1977-f2fa-a362-8faed91a19f9@microchip.com> <20230209094825.49f59208@kernel.org>
 <51134d12-1b06-6d6f-e798-7dd681a8f3ae@microchip.com> <20230209130725.0b04a424@kernel.org>
 <2d548e01b266f7b1ad19a5ea979d00bf@walle.cc> <CAEyMn7bpwusVarzHa262maJHf6XTpCW4SL0-o+YH4DGZx94+hw@mail.gmail.com>
 <87bkm1x47n.fsf@kernel.org> <2c2e656e-6dad-67d9-8da0-d507804e7df3@microchip.com>
 <aef63f6a367896950f9e61041cfcff4b99bd6c7d.camel@redhat.com> <e455e26830a0d8f2ce728461b74e6dbd4b315df5.camel@sipsolutions.net>
In-Reply-To: <e455e26830a0d8f2ce728461b74e6dbd4b315df5.camel@sipsolutions.net>
From:   Heiko Thiery <heiko.thiery@gmail.com>
Date:   Thu, 23 Feb 2023 11:44:02 +0100
Message-ID: <CAEyMn7Z-4apxxSns+eJDv6nHqGz6UvGCWa4+MmFTv4NXHyYiqw@mail.gmail.com>
Subject: Re: wilc1000 MAC address is 00:00:00:00:00:00
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Dan Williams <dcbw@redhat.com>, Ajay.Kathat@microchip.com,
        kvalo@kernel.org, michael@walle.cc, kuba@kernel.org,
        Claudiu.Beznea@microchip.com, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, Amisha.Patel@microchip.com,
        thaller@redhat.com, bgalvani@redhat.com,
        Sripad.Balwadgi@microchip.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Ajay,

Am Mi., 15. Feb. 2023 um 21:14 Uhr schrieb Johannes Berg
<johannes@sipsolutions.net>:
>
> On Fri, 2023-02-10 at 15:28 -0600, Dan Williams wrote:
> > >
> > > In wilc1000, the bus interface is up in probe but we don't have
> > > access
> > > to mac address via register until the driver starts the wilc firmware
> > > because of design limitation. This information is only available
> > > after
> > > the MAC layer is initialized.
> >
> > So... initialize the MAC layer and read the address, then stop the card
> > until dev open which reloads and reinits? That's what eg Atmel does
>
> For a more modern example, iwlwifi also ;-)
>
> You should also load the firmware async, so it becomes:
>
> probe
>  -> load firmware
>
> firmware success callback
>  - boot device
>  - read information
>  - register with mac80211
>  - shut down device
>
> mac80211 start callback
>  - boot device again
>  - etc.

Do you have a meaning about that? That sounds like a viable solution.
What do you think?

-- 
Heiko

> johannes