Message-ID: <8d6896f5-3710-0b35-582a-fb482e5f4196@gmail.com>
Date:   Mon, 27 Feb 2023 13:33:32 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [RFC 1/6] pccard: remove bcm63xx socket driver
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>,
        Dominik Brodowski <linux@dominikbrodowski.net>,
        linux-kernel@vger.kernel.org, Maxime Bizon <mbizon@freebox.fr>
Cc:     Arnd Bergmann <arnd@arndb.de>, Bjorn Helgaas <bhelgaas@google.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        H Hartley Sweeten <hsweeten@visionengravers.com>,
        Ian Abbott <abbotti@mev.co.uk>,
        Jakub Kicinski <kuba@kernel.org>,
        Kevin Cernekee <cernekee@gmail.com>,
        Lukas Wunner <lukas@wunner.de>,
        Manuel Lauss <manuel.lauss@gmail.com>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        Olof Johansson <olof@lixom.net>,
        Robert Jarzmik <robert.jarzmik@free.fr>,
        YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp>,
        bcm-kernel-feedback-list@broadcom.com,
        linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org,
        linux-mips@vger.kernel.org, linux-pci@vger.kernel.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org
References: <20230227133457.431729-1-arnd@kernel.org>
 <20230227133457.431729-2-arnd@kernel.org>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20230227133457.431729-2-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

+Maxime,

On 2/27/2023 5:34 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The bcm63xx pcmcia driver is the only nonstandard cardbus implementation,
> everything else is handled by the yenta_socket driver. Upon a closer
> look, this seems entirely unused, because:
> 
>   - There are two ports for bcm63xx in arch/mips, both of which
>     support the bcm6358 hardware, but the newer one does not
>     use this driver at all.
> 
>   - The only distro I could find for bcm63xx is OpenWRT, but they
>     do not enable pcmcia support. However they have 130 patches,
>     a lot of which are likely required to run anything at all.
> 
>   - The device list at https://deviwiki.com/wiki/Broadcom only
>     lists machines using mini-PCI cards rather than PCMCIA or
>     Cardbus devices.
> 
>   - The cardbus support is entirely made up to work with the
>     kernel subsystem, but the hardware appears to just be a normal
>     PCI host that should work fine after removing all the cardbus
>     code.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

This is probably fine because PCMCIA on BCM63xx was only needed for the 
very old and early devices like the 6348 which modern kernels are 
unlikely to be able to run on since they are usually RAM constrained 
with 16MB or 32MB of DRAM populated. Maxime, do you care if this driver 
gets removed?
-- 
Florian