Date:   Tue, 28 Feb 2023 12:06:58 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     pkshih@realtek.com, kvalo@kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] rtlwifi: rtl8192se: Remove the unused variable
 bcntime_cfg
Message-ID: <Y/3gUquaPNlaLaKt@corigine.com>
References: <20230228021132.88910-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230228021132.88910-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xSXpNVs0kAhX9pp/6OIar0Rw867T8kX0qmhulSU5MAqTyKIZx8RDPVSEJyNH?=
 =?us-ascii?Q?zRF0TVo0tl5Agm7SfT+wcbKJTn83dgaYkHnHmSM4ipGDCHhg1q4CoXMVXoLq?=
 =?us-ascii?Q?vtOdQR5eBgZjcsDmySzK+PSW8SirH1GccxJ4/1Hcz6Y+XcLCmx50KRUIzxdB?=
 =?us-ascii?Q?3tzIQN9cOrGlU0kQjeD45Hsmy+9OSuLb0ufC10obx/r5/IJ0Q8Wv4fryZeHY?=
 =?us-ascii?Q?a3uPjFEugKn6tbvnqZ2i3TqrR2bYVErwxaVMVa7RvMW6bUnvdmHTGD3x4M7a?=
 =?us-ascii?Q?BetDj8/y6gmTX/oJBiF7j+6gk6fFkVrAHCWO4azpSMKT4a2K54h+0GZjNf+L?=
 =?us-ascii?Q?NPnqOK1oVFHcurAJxyeIxojktCmi4R5UA0VBcvKo0bBK/WSnjHQ8rjhjCuh6?=
 =?us-ascii?Q?tXUOqxHicVl2EhOkHWxd7yG2l2qczjX35yJaScFG9F4yEzh6ZYT4B+9NpZjX?=
 =?us-ascii?Q?BkAaOuwwk2bTl2GXpiYs2wJdJnbrg+Uy82NJf6R5UQCBHw5dpW9JjAAsTGh9?=
 =?us-ascii?Q?2yo5a3Ar/hUx9oP9R3cMGfxuvdcw4cXrhgq4tRezzMedwHTMHH9075QlqQ3F?=
 =?us-ascii?Q?0Kt6nbsllxUq9XmL208CLFs9Za+1qCLI2UsVXHZDNPXhogStPxAIKjB4jlJs?=
 =?us-ascii?Q?A3906zw3hamLLYMmbBPBU8Zx+U6jKJyhLe2NM7ITOxrd8VMbhbpiKuES9wpv?=
 =?us-ascii?Q?C1BKwDn400m7yAQBwzk9kYm88h4cvtpawmmoJkKbkJkMZUqbzj/DZT1c/zci?=
 =?us-ascii?Q?MmD2D6jqwpjyQyEPa/ZRGXi1wDSSClVYg5++4kKap0Ib1iOzkTcsYZk4PVI6?=
 =?us-ascii?Q?j/dHlneZZHq67l4TyN02xk8arX2xoqMoaQxTAKHQig02A8qk2m4skIvhxLNm?=
 =?us-ascii?Q?Nb5va6WSigsQMToz2tnSe8WXukr92GJvfygwQu8kB22cfqhYTmB2o76Nlt5F?=
 =?us-ascii?Q?Ly+EUmbMLUGF9huT7X00BvklIi4E7HbTT4WgJG9Z1fiu3CTKOmXsWbNdAQNS?=
 =?us-ascii?Q?E6u+4BAMtJVeSJBXS5R0mHujoaG0c3BUALYu5m1dQVjBhIWkCxSOgxboJGwm?=
 =?us-ascii?Q?dqFnW5fEySHW+lxnM4VP0GM0esQbiG+sLxtyjf7HRw5QyGF3xDUrsGAqNprz?=
 =?us-ascii?Q?kCT/0wi7CLK1BOVzdm9ah9Btw2RqfF+96vTWqLI9QLnBz4oKpO9bJtvYvXIy?=
 =?us-ascii?Q?FQT0aDwhR+9ySWKyZJVYerQOkWWwsQHjxEAT+cf50U4TR6pxpcj3QzOcbztC?=
 =?us-ascii?Q?ULHtGx/vcNrMuMzNSKjDiQKjqie5SoeEO2+sjikub+o9Yyvnqfhqd8R8EVFt?=
 =?us-ascii?Q?OykkNEAZSgimNK+Qmpf0QyFbq6k+SYvoP1ol4JnvYdR4Y7CT4XJ+aRWsJSOS?=
 =?us-ascii?Q?ZDJAFJtFljdgY3yLMRcUjeuOrIcWe8UW4riHm9iPPBpbs5WR1fQzjVjApsT8?=
 =?us-ascii?Q?LOMb4dbkcu7rxTJHicypJqC9ykc1DeDtrjqS+gIQO5m3s9G1dL9szF7txvab?=
 =?us-ascii?Q?CUIYpM3ZIHPpg7GiSOsbysdE6V8uG2ew5LywJYAFJTHKo8Dm9qK0910WHpNN?=
 =?us-ascii?Q?2KE+0GSuVgL8wmQyUt2tQAXGyPznKa+3wMX841eq/uTgJclUK2KZhBzXsZ5r?=
 =?us-ascii?Q?JottzWMQt5IYe9HHvkxfPzkG3ioDdOloLYwb/ty06ADA/lUq3aS8BOdOGZ+8?=
 =?us-ascii?Q?dxwY8g=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 172e84bd-92e0-4e50-47dc-08db197beced
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 11:07:05.1577
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jPGT0cRDHEu0lHxrOA/AozMheFDLLYEvNZxS3nPIC7jSzuuBpjjfbdrZ8sAEvZs6ykDjqGCZ90L/LswKYOniSQ5Uf3mgezOER/kH/2dsafc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3831
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Tue, Feb 28, 2023 at 10:11:32AM +0800, Jiapeng Chong wrote:
> Variable bcntime_cfg is not effectively used, so delete it.
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:6: warning: variable 'bcntime_cfg' set but not used.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4240
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Hi Jiapeng Chong,

this looks good to me.

Reviewed-by: Simon Horman <simon.horman@corigine.com>

While reviewing this gcc 12.2.0 told me:

drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:25: error: unused variable 'bcn_ifs' [-Werror=unused-variable]
 1555 |         u16 bcn_cw = 6, bcn_ifs = 0xf;
      |                         ^~~~~~~
drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:13: error: unused variable 'bcn_cw' [-Werror=unused-variable]
 1555 |         u16 bcn_cw = 6, bcn_ifs = 0xf;
      |             ^~~~~~

So perhaps you could consider sending another patch to remove them too.