From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     Kalle Valo <kvalo@kernel.org>
CC:     Johannes Berg <johannes@sipsolutions.net>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 0/3] net: wireless: use struct_size where appropriate
Thread-Topic: [PATCH 0/3] net: wireless: use struct_size where appropriate
Thread-Index: AQHZSuubAdnMi1GME0C2ncvrfeHms67j5M5XgACmypA=
Date:   Tue, 28 Feb 2023 16:21:48 +0000
Message-ID: <CO1PR11MB50898A1BFF1CF83520F14565D6AC9@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20230227203927.3662811-1-jacob.e.keller@intel.com>
 <87h6v61f59.fsf@kernel.org>
In-Reply-To: <87h6v61f59.fsf@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9M/gUr9weyF+eOSPHQubz1lhF3LEir2nv0mB13PmUxF6m0u3D3CPBRLIIp5m?=
 =?us-ascii?Q?rg9zEeOSZa44TIHNWotYSTY/D6gaimooRyQKCcO1SjNo+bElCFCbEN4kVn5m?=
 =?us-ascii?Q?EuH8E4ZaaU//DxsZwDn+WTz/EBnTxZKvkvc4Uc+p20RU3jzM8Yr1YiojmfG2?=
 =?us-ascii?Q?9LZpw6ibgY401hgstt82UUJO5Br8AmtD2HBMuIA5cYR2YSSnKsUzzGhLHYnC?=
 =?us-ascii?Q?uqNAFysH7OAkT2OCPvq1clyCZXLWsL3EokCYwD2irjJzWypPcUQ039T8/xAk?=
 =?us-ascii?Q?FOFJmJogWTam5xI3tBQx/ZQ+kqCZXjVsh2o85pksjs00fy/Wp0A0Rossjo/b?=
 =?us-ascii?Q?usQ4jXOWeSXDWtjb/WpsWA3D4x0oy0mmNuTLSq3khaXFTpZAyZei9ulKemqg?=
 =?us-ascii?Q?dp+nQvM0FydlFr3Mt0uGPBPKKH8xTSuFevaooeBe4vNteqoC/SZfCIHPXjqG?=
 =?us-ascii?Q?59j2Gxzw1p48hPmh9l8XOzPX7vKsS4KV+oLPoISQXwgtZI0vH98QPYPp2khw?=
 =?us-ascii?Q?ReyH3Ahc2ZvajyjS/gj6VCX2JKCBFXQf8v1tvuJiCLKg4d/pR370BtH+FNTL?=
 =?us-ascii?Q?QGJcNkby01n43B5TkH3PAuqg9mQfJm9dL74rOKMqdGoDUeEC7TUUrkJf7XH4?=
 =?us-ascii?Q?2fiYLW0LK3ibXNmK2znHmxRmUrv6VFp+oXTLzRHzYv+N2xz+MSi48hyCbX7A?=
 =?us-ascii?Q?CZaIlbQA0E/MLPe8fPzbdkqm1NTehxAvRqUyPQZi+R2oIzSJeLZTMCNEnxRV?=
 =?us-ascii?Q?LtmkrUl/nf5Uxw8wllyfVGaREJA31uPCZvMZ2QBVSxDK2mIt2z9xG/Qeertd?=
 =?us-ascii?Q?lWNwfX9IIG2+nIXH36HCZ3tsFBOOETUpTpszGgbxCXKdyhWXxAL/uM6gAEOg?=
 =?us-ascii?Q?2W1rzwXmi/3GGNfGNMNVcLlP8un4Ln0zNzZFcbOtis/Hig/C7HQ+0peUr4NL?=
 =?us-ascii?Q?HGtOh9DUU5ZzVW5j9pX1HbuZo7orLI8+1tXI8xaDyinuCRQWqLBdkge02jdL?=
 =?us-ascii?Q?ORt23WZTHMLvk2MjrjnyIcwoO2M5ORJCkiCHTAZOW234ZfXuVnytpgNwQMLV?=
 =?us-ascii?Q?bu+ooB5rs4Sv2hfgMDVzTAPgxe0HThZuJ+GTWZ6BP/Jc0W/h7QkDCJkHzoA0?=
 =?us-ascii?Q?foKmvVJ0CcEHw4av8gGy2ZtTeNv1hDC+oT3qbHpWT8rgp8lRUIVadL/ovrW4?=
 =?us-ascii?Q?sS0p/Xu1KsDDALkc/jIng4Q19aS2iYR3iGumB6Fe5dNKtXHj6iYYp9mA+uX9?=
 =?us-ascii?Q?COfCuJ1MZtf4DjfmSVk645bzgeb4hig5Ie9I/Bq5tLuckZ6GF3oswlgpkf1M?=
 =?us-ascii?Q?yNhuoEIllwoy7L2/MFINS4WZTOooIHEcf17jYCvOxCCmUo7WQFtUHHIimPfN?=
 =?us-ascii?Q?Ts5vX9WD70QS5fljwxv4unPXc6D1mKXwH14ncPiQ8QmBeYdfFWBG47ISg5WA?=
 =?us-ascii?Q?BCJ4LYH2lsQz1/eJ4ygZQr+WHIHyYySy55h6TlPSZv7h8cCuUUZAMT227lPl?=
 =?us-ascii?Q?zIrXr45/lPwS7iw6qNvNS66+9+CDPGFj8t8isgkOB5YakdEPEJTFl+7J7/+E?=
 =?us-ascii?Q?4X+mqs67uSutIDFzjSlwrMtdzy8B0jdKZa5F5mZy?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d8b82ba-8ffb-4321-8a06-08db19a7e431
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2023 16:21:48.1585
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lIHoUc/b8YxrA7TSC1K018U7/JJ6gb1im3Mlrs56IS8n/M0cIGGcFDW0E3ttf1I9Io7Pc7LAQxjIY+V9VCwM1aYUuNnXQh8f9pRjq5YIdhs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6099
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


> -----Original Message-----
> From: Kalle Valo <kvalo@kernel.org>
> Sent: Monday, February 27, 2023 10:24 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: Johannes Berg <johannes@sipsolutions.net>; linux-wireless@vger.kernel=
.org
> Subject: Re: [PATCH 0/3] net: wireless: use struct_size where appropriate
>=20
> Jacob Keller <jacob.e.keller@intel.com> writes:
>=20
> > This series fixes a few wireless drivers to use struct_size rather than=
 open
> > coding some equivalent checks. This ensures that these size calculation=
s
> > will not overflow but instead be bounded at SIZE_MAX.
> >
> > In the first case, the code is first converted to a flexible array, whi=
ch
> > saves a few bytes of memory in addition to the fix with struct_size.
> >
> > These were caught with a coccinelle patch I recently posted at [1].
> >
> > [1]: https://lore.kernel.org/all/20230227202428.3657443-1-
> jacob.e.keller@intel.com/
> >
> > Cc: Johannes Berg <johannes@sipsolutions.net>
> > Cc: linux-wireless@vger.kernel.org
> >
> > Jacob Keller (3):
> >   wifi: ipw2x00: convert ipw_fw_error->elem to flexible array[]
> >   wifi: cfg80211: use struct_size and size_sub for payload length
> >   wifi: nl80211: convert cfg80211_scan_request allocation to *_size
> >     macros
> >
> >  drivers/net/wireless/intel/ipw2x00/ipw2200.c  |  7 +++--
> >  drivers/net/wireless/intel/ipw2x00/ipw2200.h  |  3 +--
> >  .../net/wireless/quantenna/qtnfmac/commands.c |  7 ++---
> >  net/wireless/nl80211.c                        | 26 ++++++++++---------
> >  4 files changed, 22 insertions(+), 21 deletions(-)
>=20
> I don't see the actual patches, only the cover letter. Also nothing on
> patchwork:
>=20
> https://patchwork.kernel.org/project/linux-wireless/list/?state=3D*
>=20

Hmm.. Let me resend.

Thanks,
Jake

> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>=20
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa=
tch
> es