Message-ID: <99a9d4a2-d032-1c9d-90c6-3a68f6b3a092@intel.com>
Date:   Tue, 28 Feb 2023 08:29:13 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 0/3] net: wireless: use struct_size where appropriate
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>
CC:     Kalle Valo <kvalo@kernel.org>, <linux-wireless@vger.kernel.org>
References: <20230228162241.3874991-1-jacob.e.keller@intel.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230228162241.3874991-1-jacob.e.keller@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHArTHdRQnFLOTdlbmhmUWY3K1pqQnpxbC9ZU1FOZHRrN1hqU0tsV0xSMGZi?=
 =?utf-8?B?Z1h6WDl2VEFGRlVYd0pQOGZUSEMzbmNhNm5BL0dYYkxYSi9hc1dpdEtsbVdm?=
 =?utf-8?B?OWs3NlMra0JOSk80SE8yOUd2U2ZQbElnWUtHTjdZSllOSldFWHM0cG0xRmJy?=
 =?utf-8?B?RnowSUEwTVpaRFlBZ0JPcU85NmlDRi95ZWRXUEpweFpoaFc3cTBxM1lvKzc3?=
 =?utf-8?B?NkZpZW5rdHpWNFJyV0VzNW8zbGhEQ3JWNXgrRlllV09RZ054UFQwRUFxZlMr?=
 =?utf-8?B?aVBWaWFYclQ1TDFLdk1OSkRsRVozdXJVK0ZYdlBqMDVlNUU1STRMaVUrcDMy?=
 =?utf-8?B?Q09PdmRtOEJvR1I2YW5CMHhKQ0NzYXYvU3o1Y3hMdE9nN2JzVXlqUkNEanNY?=
 =?utf-8?B?cHRwcmU0cjdMN1lZd0J2Mm9DL3hYQWF1SXZoR2NrZlg1eW9VT3doajNBTDhp?=
 =?utf-8?B?anFjSXFJQ09DN3Rud0pnZ05NM1lRR21Da2QzcHhFRDB1VmZnVjhtempmM0Jz?=
 =?utf-8?B?anhmTUUwZTFTclk1NERmL2thcVRqYnJ0US9sYVpnYUNlTUtkUDFMSGgxNzF6?=
 =?utf-8?B?R1d0RmRUUkFjenJ4dkU5NEhBYkJmcHNaenBVTzZDVHlDSVViSzhnMXJOS09P?=
 =?utf-8?B?YnRNeHVtQXhDV1V1V3Q0aTFwa1BNVjNlUk4rVlN1Y1RVUTdHYVAzT1lCeS9y?=
 =?utf-8?B?WE5zc1N1M1N0dFBQaE9aTXhsajc5ZnFlRmZMNXVyako0MnFuNjQ2TU5Ibjlh?=
 =?utf-8?B?WHZxVkR0dnF3NGIwV3YwajltWjN2allvNnkvRDNFVWxjdEF5ZHV5YVZFYUhQ?=
 =?utf-8?B?OS9ZRFYyS3o5Q01wT3hjdlBJUjBCTngyak9mZFZQaWlpM1BhT29OWVB5S0R0?=
 =?utf-8?B?NlhteWlxVkdCaWYzOE56TU9SNjZHR3ZrdDZ3M3g0a2FpaytUcWtweUtiQm10?=
 =?utf-8?B?S0JkK1pBeHE3cXZlZ3k2cG9WRmJ0TFZoVGhoMzBWU2xDbndaeXRtYjE3WkNS?=
 =?utf-8?B?SXpIcXluQWE4dzNVRHFLZUU0MGpOTGxZK0k1UW1jZ05SMnFHcG1VNFF4TUp5?=
 =?utf-8?B?QXp4UjNXMmtVMXkzaXNHY2pId3VCVkZrYnFYbXc1UHlGUmk4VEw4KzlGM3Nk?=
 =?utf-8?B?d25HVkIxUndEN01FcFFvNFBteGJSclFyQ2t5UVptcEVNc2UvTjJEalo3N0U3?=
 =?utf-8?B?ZEZyNFBIOThaRnM2YTFhVWxJM3lUTmZnRUM3Z3Y1aWVYVnhXdEtJYlN5Rzhr?=
 =?utf-8?B?NmVwWkZSUGFaSFVYd1FEeWVkVnJ2cWF3OFpmY0dlY3Y5bnNjREkxTm90T2l3?=
 =?utf-8?B?d1dlYnZIZGNiSnRIL2R6c2Z3QWRKK21YM2htbzJEbWRDQ0JERmhLaDI3ZnhG?=
 =?utf-8?B?TUU4ZXBFdVhWQ3ZHSVJqbHFwdWtUTi9IMDJxUW0rK3lMRFRYZjRLQ0QvblhE?=
 =?utf-8?B?Nm52c2RZT3NJcklGY3BETUxSMjhwQTU1TGNXRkh4SFhGMkdDRzFDMStNeUIw?=
 =?utf-8?B?UEpFeTZQZlpiLzJWaFhhcVNwRW5ISng3YURxVGpkdXJlNTBKanJnd3Ivb3V6?=
 =?utf-8?B?OVZDZ2w4NCtDMFJLMFhlY25HU0RaT0toUk1JaDhVajJzSjB1bFlicjNLZzN4?=
 =?utf-8?B?ZWJvTCtuelpBYzNBUnZtZ2N3WWFsTSs0S0p1QityUnVNbHh1VnlyVEw2UkN2?=
 =?utf-8?B?QUthZ3RveTNTbm1JNnd1bnVoVFk2NUxiZ2hHMTBiVlJsdkI1bHdUejloMnlr?=
 =?utf-8?B?a3ZJRWdxRHJwS0xtV1Y2TGdRYTZJY3NqSVlVYVdPTzZOQjhIVjhtUSt4czZ3?=
 =?utf-8?B?U25UMVQwVXJQM3ZNYTdvb1Z1cURHajZUeVAvUlZZZFcvUTZNbkRoU01MU2s3?=
 =?utf-8?B?VHRDRGY5VU9hdFFDdW45T2NFOGFCQmprZnNpR2dmbDh6REJaSlQ1dmVuR09q?=
 =?utf-8?B?SHpja0dOZGhpNklWNkdxQ3pXNWZSMHRhTXhqK2U1SkxlZzNoL2tSK0VNTkJT?=
 =?utf-8?B?QkRkcE5pVlowanptMVFucTNlUnViSlA2TUFxTzRNQ1NGdHBWNzhXR29CdHB4?=
 =?utf-8?B?dzFQN0tRVVNGM25SZHJqWkN3OFJ2U0RsNWI1d0hVbHFIWVdRdXRnYVRFRitR?=
 =?utf-8?B?L2FrNHY0K09scHFITkV3ck0vVGJYYlNhS0UxZUdtQURKUW43M1NFTklPZ1Rt?=
 =?utf-8?B?Mmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b17f459-cc99-499d-9da8-08db19a8ee64
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 16:29:14.9703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vJt7OS416iss8vkHiNIJa5ey3NlE7XtwLRvMwP9iQWwisA0iGwZ6spmtHa5GT2hDu3zzEXWlKU+BizIyZPZW2qkHB2tj5wPrs+UtwB+LeHI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7979
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


On 2/28/2023 8:22 AM, Jacob Keller wrote:
> This series fixes a few wireless drivers to use struct_size rather than open
> coding some equivalent checks. This ensures that these size calculations
> will not overflow but instead be bounded at SIZE_MAX.
> 
> In the first case, the code is first converted to a flexible array, which
> saves a few bytes of memory in addition to the fix with struct_size.
> 
> These were caught with a coccinelle patch I recently posted at [1].
> 
> [1]: https://lore.kernel.org/all/20230227202428.3657443-1-jacob.e.keller@intel.com/
> 
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: linux-wireless@vger.kernel.org
> 
> Jacob Keller (3):
>   wifi: ipw2x00: convert ipw_fw_error->elem to flexible array[]
>   wifi: cfg80211: use struct_size and size_sub for payload length
>   wifi: nl80211: convert cfg80211_scan_request allocation to *_size
>     macros
> 
>  drivers/net/wireless/intel/ipw2x00/ipw2200.c  |  7 +++--
>  drivers/net/wireless/intel/ipw2x00/ipw2200.h  |  3 +--
>  .../net/wireless/quantenna/qtnfmac/commands.c |  7 ++---
>  net/wireless/nl80211.c                        | 26 ++++++++++---------
>  4 files changed, 22 insertions(+), 21 deletions(-)
> 

ugh sorry for the spam.. the actual patches didn't get cc'd to
linux-wireless. I've fixed that now.

Thanks,
Jake