Message-ID: <a8798dce4ae87aee64dfd56721b1668f8c969951.camel@sipsolutions.net>
Subject: Re: [PATCH 1/3] wifi: ipw2x00: convert ipw_fw_error->elem to
 flexible array[]
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Jacob Keller <jacob.e.keller@intel.com>
Cc:     Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org,
        Stanislav Yakovlev <stas.yakovlev@gmail.com>
Date:   Tue, 28 Feb 2023 18:16:07 +0100
In-Reply-To: <20230228162827.3876606-1-jacob.e.keller@intel.com>
References: <20230228162827.3876606-1-jacob.e.keller@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-02-28 at 08:28 -0800, Jacob Keller wrote:
>=20
> @@ -1247,7 +1247,6 @@ static struct ipw_fw_error *ipw_alloc_error_log(str=
uct ipw_priv *priv)
>  	error->config =3D priv->config;
>  	error->elem_len =3D elem_len;
>  	error->log_len =3D log_len;
> -	error->elem =3D (struct ipw_error_elem *)error->payload;
>  	error->log =3D (struct ipw_event *)(error->elem + elem_len);

I really don't know this driver, it's ancient, but that last line looks
wrong to me already, elem_len doesn't seem like # of elems?

But I guess this patch changes nothing here, so hey. Don't think there's
much value in the change either, this driver isn't going to get touched
any more, just removed eventually ;)

johannes