Message-ID: <80ddafb7c3d04b145817bb4c909ab736d06f1e1e.camel@sipsolutions.net>
Subject: Re: [PATCH 1/3] wifi: ipw2x00: convert ipw_fw_error->elem to
 flexible array[]
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Jacob Keller <jacob.e.keller@intel.com>
Cc:     Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org,
        Stanislav Yakovlev <stas.yakovlev@gmail.com>
Date:   Wed, 01 Mar 2023 21:53:15 +0100
In-Reply-To: <99bc0165-814b-918f-1d62-4256836ab9a8@intel.com>
References: <20230228162827.3876606-1-jacob.e.keller@intel.com>
         <a8798dce4ae87aee64dfd56721b1668f8c969951.camel@sipsolutions.net>
         <d393ba90-ecdd-ffea-540b-d6db15571d5b@intel.com>
         <7f996d2efd23cefd17074edaeed0a6bbbd9f1a99.camel@sipsolutions.net>
         <99bc0165-814b-918f-1d62-4256836ab9a8@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-03-01 at 12:49 -0800, Jacob Keller wrote:
>=20
> I can drop this one out of the series if you don't have an intention of
> taking it, or I can refactor to just use size_add and array_size without
> converting it to flexible array, which would prevent that coccinelle
> patch from complaining and at least ensure that we can't overflow size
> and under-allocate.
>=20
> Do you have a preference?
>=20

Ah, it's up to Kalle, not me :-)

I think it's OK to do, and if it gets rid of drive-by submissions from
the coccinelle patch later, I guess it's better to take it now. And you
already have it anyway.

I might prefer though if you sent the drivers and cfg80211 patches
separately, since that's usually Kalle vs. me applying it, and if it's
in a same series we tend to end up wondering if there's a dependency or
something, which is clearly not the case here.

johannes