Message-ID: <2f8deec4-1bbb-aaf0-dd8d-9d31c0225811@intel.com>
Date:   Wed, 1 Mar 2023 13:01:00 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 1/3] wifi: ipw2x00: convert ipw_fw_error->elem to flexible
 array[]
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>
CC:     Kalle Valo <kvalo@kernel.org>, <linux-wireless@vger.kernel.org>,
        "Stanislav Yakovlev" <stas.yakovlev@gmail.com>
References: <20230228162827.3876606-1-jacob.e.keller@intel.com>
 <a8798dce4ae87aee64dfd56721b1668f8c969951.camel@sipsolutions.net>
 <d393ba90-ecdd-ffea-540b-d6db15571d5b@intel.com>
 <7f996d2efd23cefd17074edaeed0a6bbbd9f1a99.camel@sipsolutions.net>
 <99bc0165-814b-918f-1d62-4256836ab9a8@intel.com>
 <80ddafb7c3d04b145817bb4c909ab736d06f1e1e.camel@sipsolutions.net>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <80ddafb7c3d04b145817bb4c909ab736d06f1e1e.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmpNSkM2VXhSRTVYMDdnNENSeWlLTXNBNjhFRkxQZlZLUnF2c0NHL3hKYnhv?=
 =?utf-8?B?akUwL281WXBaOC94cytZcDZZSlFPZk9hcWt0MEs3M3AycnArQWN1S1JtQkx6?=
 =?utf-8?B?b1BxaFNDUkdtR2J4RjZieUxqRFM5RGhGbTc5VDkvZTZ0OStwTzBLVVB4M2gr?=
 =?utf-8?B?NzArYlloTGxYMTZVMUNjQUhUcnhpdEJ4MzJQR3ZQd3BncmFBSEFHeWZQNjN0?=
 =?utf-8?B?d24yRzhFZTVuSkw1bTZyVjQyTUJjWmkyMkt3cFZxZ0JjT0JiUzV3U1FUN3Rj?=
 =?utf-8?B?ejBGV0Q2N1R6aEIxR2QyN2UyZFNNTjdGM2JjeXZ6NDk4d2cvclNFdDZUM1k4?=
 =?utf-8?B?WHd3anhJV3lRNnlCc3o2aDBZY0pMa0N5TFM0UXh2YWFLWXBvb0ZQeVFDUjVr?=
 =?utf-8?B?cGhqOS91R1dCOHNWTktZUGpQSzJHUXFMSzM1MllYdEhpSC9zcnBTNUcvcVUx?=
 =?utf-8?B?WDhXcTJlVitHdW9Na1AvcEFnZGdueFhLRnc5RDh5SkNtekxpNkVNQWtWOXVr?=
 =?utf-8?B?bzlLYzhQTGFuUmxBdm0zUnhidCtnRFRKaE5CTUlPajhFUWFTeVB1WktnK2dM?=
 =?utf-8?B?UmdVZmNIQ2ttVG9FR1I0d1BtNkFVZmxnbVZRSWtkTnBtb0NCZHl4bXl3a0N0?=
 =?utf-8?B?N0RwS0pGajlGY3BqbDhZeWFNcm1UdTZEMlBXcHZPN3Zxblk4aHpEdGdEclFJ?=
 =?utf-8?B?R2duYmk5USt0Vlh4M2NsZld1R0VLN252V3JMcEgrTk9NS2pkekg1Q2RQeG1B?=
 =?utf-8?B?UHJqSTQxS3dBbFVRM1puQ3BhU2poMU5ZUk5BT1l0ajZ6aVFNOVR4OXJ0SEhn?=
 =?utf-8?B?RTI3YWYzc1Y0ZGxpSXFwTlRVOTEra1hsNTlhMVc2U3cwcHRhYmh0dFM1Y09K?=
 =?utf-8?B?aGQ0YkpMU3pzUFAyK3R6YVZCTmEzeDBYSnVjN09mRDVVdVVTdEkrUDZQNFVF?=
 =?utf-8?B?UjN5OVNxQ1lrcDZHRktUc0UydHVqNElHQVZmZlFxelBabTg4UVB5T3lET0NX?=
 =?utf-8?B?eFZLci96amlBRWllTytwNUdpT1hZNktiMG81SnFFZjU1cUpOZjBDK3VJUkp0?=
 =?utf-8?B?bW0rTFpydVNxWXV0ZUt2NXpZSkRVR0hxRk50a2w3TlVoSWFCT243NWRMbjBz?=
 =?utf-8?B?MzhwQVdFNStuR1BYbEh1QmVmaFZkM3pEQkdZZEFFV0hIQ2dubVpuNU5GdTht?=
 =?utf-8?B?VEh2MXR4RnlyQlFuSDUyVmdrbWR5QXNLZzJqZzVVczNhZURBSlRQcEFSditX?=
 =?utf-8?B?VjU4dzNIbVlyM2xlanBvR1JjYmNadEdVRW00eENIeXBpRUFoU3AySFlkcnVU?=
 =?utf-8?B?ejdiQ1JkZ0dRaVRXVGxsRVJpeU5ZMnd5OVk3V29XNFh4OEE5cmJmcDYxMUxj?=
 =?utf-8?B?TjRwWW9CcWpSZVBiaENIWTRNcHJqMGN6UzQ2Q2JDbE93RFRkVm9hMEhYbzdj?=
 =?utf-8?B?NWdCZk90d05KTkpvNndUNDhLM1lzQ0lRck1Hem4rOFo0RlI5bjhyMlMxMlJH?=
 =?utf-8?B?YUViVytLZ2VHMEJiR0FZQmRrRGZldkZmS2JacXJyVnc1eHBvWlI4c1Y3S1Bt?=
 =?utf-8?B?MmROK2pxN3VJeHlVY3VWdndBTFhDZXdZbmY0bWg4Z1E2am8xQjJjajNEbmhh?=
 =?utf-8?B?cGxFelpQTDFpeW81cjNTMEFwU0ljYnk0dUh1ZmRuK0h6NHNQajVIVkVEcnMv?=
 =?utf-8?B?anZmbWdkU0RQTWw1STBSVkhwRkRQM2hsS3gxRUoyYjVmR2dLNCt4Qm9XSEhy?=
 =?utf-8?B?WlFCL3lzRmhrUTBGcHdiWG5pcG5HZVJYUEFVcmVmZG1FNkR5eHpLSjdOb1Vp?=
 =?utf-8?B?ZUJlUjlJZmxid0ZzeHU0QTFiV1FCTk1taEx4RUxMeUwwQ20vcHhpc1lrZldC?=
 =?utf-8?B?a1VuS00wU3pkcGlhOWJ6TVNxUm1FSzNmUmRXTlA0dGo0T01HUUwybmZZdkw2?=
 =?utf-8?B?VFhDUG9mbFMwenpZa280QlFpN0dUNnZjcUtFMDViSmJMNDJMVlJSTXB0aURO?=
 =?utf-8?B?Z3VDZ3ZSN2ZsaUtrWDB1aUNCaitoUU1jeFJKdTBIQnRqQUhHSHJtWDFIZDdB?=
 =?utf-8?B?ZEd6dG82bG1ibEJqb1dEdWJWaTBVYnRSa1l6UkU3TlFWUWswZlQ5VXJ2eFky?=
 =?utf-8?B?OU1SZGlxZmxDMzdsYkJyUy9QbHdIdE9PVG5TMWtGQzVqcyt1UDZyUXRaUzZ3?=
 =?utf-8?B?dEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 42d64da0-d0be-4665-b249-08db1a9810d3
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2023 21:01:02.6935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OhfW4ss3vgVgMcdHO+rUzjsQTqMnngWOIuhptr1HN5PXOarRvHuaZ25cUHs+8tRZBVErlknUSGyFs7NFXgxsXQTot1dUzz3eOeqytsiwWC0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7416
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


On 3/1/2023 12:53 PM, Johannes Berg wrote:
> On Wed, 2023-03-01 at 12:49 -0800, Jacob Keller wrote:
>>
>> I can drop this one out of the series if you don't have an intention of
>> taking it, or I can refactor to just use size_add and array_size without
>> converting it to flexible array, which would prevent that coccinelle
>> patch from complaining and at least ensure that we can't overflow size
>> and under-allocate.
>>
>> Do you have a preference?
>>
> 
> Ah, it's up to Kalle, not me :-)
> 
> I think it's OK to do, and if it gets rid of drive-by submissions from
> the coccinelle patch later, I guess it's better to take it now. And you
> already have it anyway.
> 
> I might prefer though if you sent the drivers and cfg80211 patches
> separately, since that's usually Kalle vs. me applying it, and if it's
> in a same series we tend to end up wondering if there's a dependency or
> something, which is clearly not the case here.
> 
> johannes

Sure. I'll send them separately in v2.

Thanks,
Jake