Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEACCC7EE30 for ; Wed, 1 Mar 2023 23:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229944AbjCAXp3 (ORCPT ); Wed, 1 Mar 2023 18:45:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbjCAXp0 (ORCPT ); Wed, 1 Mar 2023 18:45:26 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43ECB2333A; Wed, 1 Mar 2023 15:44:57 -0800 (PST) Received: from mercury (unknown [185.254.75.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 011E566023A1; Wed, 1 Mar 2023 23:43:53 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1677714233; bh=F+cZ+xDuekZhvpQI6VN6wkOdiaibL0XhB6hG3ryOj8E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dzCs/Tm9RSF8obSF20Si7kicthqzvDNKc0LEyZ/LT3XbIHWQZIVgfzN4ExOkzO8NJ lWUfgMqSTjI9TkKkd040M1hY1jQDw4TxO6favlO1RPjGjfCPWRRLqk6aOslCKf6e3o i2+/FqlsKmBk8NuTMrgB4hdqMg33alpN0gwEz7wtzNDNAFKJpjmnTvhJyVSnpSKzuu hu4bn5l4fnOEMFIDMpShkAoNaJjXy1lU+1fV6CpYhB896ljnVwaJD69yd3bwEmZgek kaBy3VsggBld0JJRhg8GtDkJJpjlysSQxCTVEJqJJXotG5InA+EG6D1sq97Kf2wxxz gsB3GMOtnNeLQ== Received: by mercury (Postfix, from userid 1000) id 30A9D1061E59; Thu, 2 Mar 2023 00:43:50 +0100 (CET) Date: Thu, 2 Mar 2023 00:43:50 +0100 From: Sebastian Reichel To: Rob Herring Cc: Krzysztof Kozlowski , devicetree@vger.kernel.org, Miguel Ojeda , Benson Leung , Guenter Roeck , Stephen Boyd , Andrzej Hajda , Neil Armstrong , Robert Foss , Thierry Reding , Sam Ravnborg , MyungJoo Ham , Chanwoo Choi , Linus Walleij , Bartosz Golaszewski , Pavel Machek , Lee Jones , Mauro Carvalho Chehab , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wolfgang Grandegger , Kalle Valo , Mark Brown , Greg Kroah-Hartman , linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org, linux-wireless@vger.kernel.org, linux-pm@vger.kernel.org, alsa-devel@alsa-project.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples Message-ID: <4c4b6904-69b8-4e33-9c35-a5a6a855528d@mercury.local> References: <20230228215433.3944508-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iicycb2qvy4rthvm" Content-Disposition: inline In-Reply-To: <20230228215433.3944508-1-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --iicycb2qvy4rthvm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Feb 28, 2023 at 03:54:33PM -0600, Rob Herring wrote: > SPI and I2C bus node names are expected to be "spi" or "i2c", > respectively, with nothing else, a unit-address, or a '-N' index. A > pattern of 'spi0' or 'i2c0' or similar has crept in. Fix all these > cases. Mostly scripted with the following commands: >=20 > git grep -l '\si2c[0-9] {' Documentation/devicetree/ | xargs sed -i -e 's= /i2c[0-9] {/i2c {/' > git grep -l '\sspi[0-9] {' Documentation/devicetree/ | xargs sed -i -e 's= /spi[0-9] {/spi {/' >=20 > With this, a few errors in examples were exposed and fixed. >=20 > Signed-off-by: Rob Herring > --- Acked-by: Sebastian Reichel # for power-s= upply -- Sebastian =2E.. > .../devicetree/bindings/power/supply/bq2415x.yaml | 2 +- > .../devicetree/bindings/power/supply/bq24190.yaml | 2 +- > .../devicetree/bindings/power/supply/bq24257.yaml | 4 ++-- > .../devicetree/bindings/power/supply/bq24735.yaml | 2 +- > .../devicetree/bindings/power/supply/bq2515x.yaml | 2 +- > .../devicetree/bindings/power/supply/bq25890.yaml | 2 +- > .../devicetree/bindings/power/supply/bq25980.yaml | 2 +- > .../devicetree/bindings/power/supply/bq27xxx.yaml | 15 ++++++++------- > .../bindings/power/supply/lltc,ltc294x.yaml | 2 +- > .../bindings/power/supply/ltc4162-l.yaml | 2 +- > .../bindings/power/supply/maxim,max14656.yaml | 2 +- > .../bindings/power/supply/maxim,max17040.yaml | 4 ++-- > .../bindings/power/supply/maxim,max17042.yaml | 2 +- > .../bindings/power/supply/richtek,rt9455.yaml | 2 +- > .../bindings/power/supply/ti,lp8727.yaml | 2 +- =2E.. > diff --git a/Documentation/devicetree/bindings/power/supply/bq2415x.yaml = b/Documentation/devicetree/bindings/power/supply/bq2415x.yaml > index f7287ffd4b12..13822346e708 100644 > --- a/Documentation/devicetree/bindings/power/supply/bq2415x.yaml > +++ b/Documentation/devicetree/bindings/power/supply/bq2415x.yaml > @@ -77,7 +77,7 @@ additionalProperties: false > =20 > examples: > - | > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > diff --git a/Documentation/devicetree/bindings/power/supply/bq24190.yaml = b/Documentation/devicetree/bindings/power/supply/bq24190.yaml > index 001c0ffb408d..d3ebc9de8c0b 100644 > --- a/Documentation/devicetree/bindings/power/supply/bq24190.yaml > +++ b/Documentation/devicetree/bindings/power/supply/bq24190.yaml > @@ -75,7 +75,7 @@ examples: > charge-term-current-microamp =3D <128000>; > }; > =20 > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > diff --git a/Documentation/devicetree/bindings/power/supply/bq24257.yaml = b/Documentation/devicetree/bindings/power/supply/bq24257.yaml > index cc45939d385b..eb064bbf876c 100644 > --- a/Documentation/devicetree/bindings/power/supply/bq24257.yaml > +++ b/Documentation/devicetree/bindings/power/supply/bq24257.yaml > @@ -84,7 +84,7 @@ examples: > - | > #include > #include > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > @@ -104,7 +104,7 @@ examples: > - | > #include > #include > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > diff --git a/Documentation/devicetree/bindings/power/supply/bq24735.yaml = b/Documentation/devicetree/bindings/power/supply/bq24735.yaml > index 388ee16f8a1e..af41e7ccd784 100644 > --- a/Documentation/devicetree/bindings/power/supply/bq24735.yaml > +++ b/Documentation/devicetree/bindings/power/supply/bq24735.yaml > @@ -77,7 +77,7 @@ examples: > - | > #include > =20 > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > diff --git a/Documentation/devicetree/bindings/power/supply/bq2515x.yaml = b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml > index 1a1b240034ef..845822c87f2a 100644 > --- a/Documentation/devicetree/bindings/power/supply/bq2515x.yaml > +++ b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml > @@ -73,7 +73,7 @@ examples: > constant-charge-voltage-max-microvolt =3D <4000000>; > }; > #include > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.yaml = b/Documentation/devicetree/bindings/power/supply/bq25890.yaml > index dae27e93af09..0ad302ab2bcc 100644 > --- a/Documentation/devicetree/bindings/power/supply/bq25890.yaml > +++ b/Documentation/devicetree/bindings/power/supply/bq25890.yaml > @@ -102,7 +102,7 @@ unevaluatedProperties: false > examples: > - | > #include > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > diff --git a/Documentation/devicetree/bindings/power/supply/bq25980.yaml = b/Documentation/devicetree/bindings/power/supply/bq25980.yaml > index b687b8bcd705..b70ce8d7f86c 100644 > --- a/Documentation/devicetree/bindings/power/supply/bq25980.yaml > +++ b/Documentation/devicetree/bindings/power/supply/bq25980.yaml > @@ -95,7 +95,7 @@ examples: > }; > #include > #include > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > diff --git a/Documentation/devicetree/bindings/power/supply/bq27xxx.yaml = b/Documentation/devicetree/bindings/power/supply/bq27xxx.yaml > index 347d4433adc5..309ea33b5b25 100644 > --- a/Documentation/devicetree/bindings/power/supply/bq27xxx.yaml > +++ b/Documentation/devicetree/bindings/power/supply/bq27xxx.yaml > @@ -75,15 +75,16 @@ additionalProperties: false > =20 > examples: > - | > - i2c0 { > + bat: battery { > + compatible =3D "simple-battery"; > + voltage-min-design-microvolt =3D <3200000>; > + energy-full-design-microwatt-hours =3D <5290000>; > + charge-full-design-microamp-hours =3D <1430000>; > + }; > + > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > - bat: battery { > - compatible =3D "simple-battery"; > - voltage-min-design-microvolt =3D <3200000>; > - energy-full-design-microwatt-hours =3D <5290000>; > - charge-full-design-microamp-hours =3D <1430000>; > - }; > =20 > bq27510g3: fuel-gauge@55 { > compatible =3D "ti,bq27510g3"; > diff --git a/Documentation/devicetree/bindings/power/supply/lltc,ltc294x.= yaml b/Documentation/devicetree/bindings/power/supply/lltc,ltc294x.yaml > index 774582cd3a2c..e68a97cb49fe 100644 > --- a/Documentation/devicetree/bindings/power/supply/lltc,ltc294x.yaml > +++ b/Documentation/devicetree/bindings/power/supply/lltc,ltc294x.yaml > @@ -54,7 +54,7 @@ additionalProperties: false > =20 > examples: > - | > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > battery@64 { > diff --git a/Documentation/devicetree/bindings/power/supply/ltc4162-l.yam= l b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml > index cfffaeef8b09..29d536541152 100644 > --- a/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml > +++ b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml > @@ -54,7 +54,7 @@ additionalProperties: false > =20 > examples: > - | > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > charger: battery-charger@68 { > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max1465= 6.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max14656.yaml > index 711066b8cdb9..b444b799848e 100644 > --- a/Documentation/devicetree/bindings/power/supply/maxim,max14656.yaml > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max14656.yaml > @@ -32,7 +32,7 @@ additionalProperties: false > examples: > - | > #include > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max1704= 0.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17040.yaml > index 3a529326ecbd..2627cd3eed83 100644 > --- a/Documentation/devicetree/bindings/power/supply/maxim,max17040.yaml > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max17040.yaml > @@ -68,7 +68,7 @@ unevaluatedProperties: false > =20 > examples: > - | > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > @@ -82,7 +82,7 @@ examples: > }; > - | > #include > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max1704= 2.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml > index 64a0edb7bc47..085e2504d0dc 100644 > --- a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml > @@ -69,7 +69,7 @@ additionalProperties: false > =20 > examples: > - | > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > diff --git a/Documentation/devicetree/bindings/power/supply/richtek,rt945= 5.yaml b/Documentation/devicetree/bindings/power/supply/richtek,rt9455.yaml > index 27bebc1757ba..07e38be39f1b 100644 > --- a/Documentation/devicetree/bindings/power/supply/richtek,rt9455.yaml > +++ b/Documentation/devicetree/bindings/power/supply/richtek,rt9455.yaml > @@ -68,7 +68,7 @@ additionalProperties: false > examples: > - | > #include > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > diff --git a/Documentation/devicetree/bindings/power/supply/ti,lp8727.yam= l b/Documentation/devicetree/bindings/power/supply/ti,lp8727.yaml > index ce6fbdba8f6b..3a9e4310b433 100644 > --- a/Documentation/devicetree/bindings/power/supply/ti,lp8727.yaml > +++ b/Documentation/devicetree/bindings/power/supply/ti,lp8727.yaml > @@ -61,7 +61,7 @@ additionalProperties: false > examples: > - | > #include > - i2c0 { > + i2c { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 =2E.. --iicycb2qvy4rthvm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmP/4zIACgkQ2O7X88g7 +pqxgBAAj3F4gb6RlI0Z6x4ZQhCWN+DLukelA2aUhkYhJyBC2UXCy5KWL1cNzB6P Y/hjl2FRmX0zNrcfRZ8kPynFwBHGbqcob8mgiAmOxCCFjczYKEIBMDbV3dZ6RDPA gz2uAVm2ioYkgXNjee6TC9knDQ34wmmkR1MwV2u7V4YVH/Xvxu164dQE1ZAeMs8I dXJByJltLKNqRQtOQabhGSP3+6//tZ3Cu/b+Zmdk+f+r+VTvvsWH+rJlxLKJbiE3 znCN7kp3Ty1yvzd8PgM+MDt0o4mXlnfcfX5Vb+PtVTwMMJVtHvCFDYZL2Z71mwQr 8R49nVhm4pkHMpI5nZz/eYXmrsU/hpRBSVbLhd+oSNI76YqPpm/+xGWKF5JZgMIm YAxRZjxs45EP2ST8nMa7/SYXygYCp9qekwcN39+IV2LSgRkjo1Iz+qJn5sOXvYMb dJ/q0IGA8cWQ4lG3LNzwAVkfQMzfw8OFFxbTVxDFDVBM/mAHr06M86TGcLyGEYxa r5YDSv8596Ep4y67xHrdzXCLASbYgQANlOBoNkX/ZMm3YcCGXsHSl/DQdGw5KSEr 4zeoAsdANn6jGsLJurLrMFXTXcKMUEk9vHjE+N+bEjBxrMFQ9QyIk9d5MlCdp1Tn ptHuPPrunQ82d7+YC/fRCc28y/rDpEOlrFfdXej3Z3IJIkLQusE= =cMEP -----END PGP SIGNATURE----- --iicycb2qvy4rthvm--