Message-ID: <e74f9d95-acfe-5150-6648-eb165f620042@quicinc.com>
Date:   Thu, 2 Mar 2023 17:31:27 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v2 07/23] wifi: wireless: correct validation 6G Band for
 primary channel
To:     <gregory.greenman@intel.com>, <johannes@sipsolutions.net>
CC:     <linux-wireless@vger.kernel.org>,
        Mordechay Goodstein <mordechay.goodstein@intel.com>,
        <ath11k@lists.infradead.org>
References: <20230301100935.170922-1-gregory.greenman@intel.com>
 <20230301115906.314faf725255.I5e27251ac558297553b590d3917a7b6d1aae0e74@changeid>
Content-Language: en-US
From:   Wen Gong <quic_wgong@quicinc.com>
In-Reply-To: <20230301115906.314faf725255.I5e27251ac558297553b590d3917a7b6d1aae0e74@changeid>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/1/2023 6:09 PM, gregory.greenman@intel.com wrote:
...
>   	 */
> -	if (channel->band == NL80211_BAND_6GHZ &&
> -	    (freq == channel->center_freq ||
> -	     abs(freq - channel->center_freq) > 80))
> +	if (freq == channel->center_freq)
>   		return channel;
>   
freq is KHz, channel->center_freq is MHz, so should change to if (freq / 
1000 == channel->center_freq)?
>   	alt_channel = ieee80211_get_channel_khz(wiphy, freq);
>   	if (!alt_channel) {
> -		if (channel->band == NL80211_BAND_2GHZ) {
> +		if (channel->band == NL80211_BAND_2GHZ ||
> +		    channel->band == NL80211_BAND_60GHZ) {

it should be NL80211_BAND_6GHZ, NOT 60GHZ?

...