MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date:   Mon, 06 Mar 2023 09:16:54 +0100
From:   Robin van der Gracht <robin@protonic.nl>
To:     Rob Herring <robh@kernel.org>
Cc:     devicetree@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-leds@vger.kernel.org, linux-media@vger.kernel.org,
        netdev@vger.kernel.org, linux-can@vger.kernel.org,
        linux-wireless@vger.kernel.org, linux-pm@vger.kernel.org,
        alsa-devel@alsa-project.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples
Organization: Protonic Holland
Reply-To: robin@protonic.nl
Mail-Reply-To: robin@protonic.nl
In-Reply-To: <CANiq72mm9qX8uuS2y_vvtcza2hAgG3zFEy24koQTfSEOWkKDYQ@mail.gmail.com>
References: <20230228215433.3944508-1-robh@kernel.org>
 <CANiq72mm9qX8uuS2y_vvtcza2hAgG3zFEy24koQTfSEOWkKDYQ@mail.gmail.com>
Message-ID: <61190cb766083d73ef3b1455dcf3ff61@protonic.nl>
User-Agent: Roundcube Webmail/1.3.1 
Precedence: bulk

> From: Rob Herring <robh@kernel.org>
> Date: Tue, Feb 28, 2023 at 10:54 PM
> Subject: [PATCH] dt-bindings: Fix SPI and I2C bus node names in 
> examples
> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: <devicetree@vger.kernel.org>, Miguel Ojeda <ojeda@kernel.org>,
> Benson Leung <bleung@chromium.org>, Guenter Roeck
> <groeck@chromium.org>, Stephen Boyd <sboyd@kernel.org>, Andrzej Hajda
> <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>,
> Robert Foss <rfoss@kernel.org>, Thierry Reding
> <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org>, MyungJoo
> Ham <myungjoo.ham@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>,
> Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski
> <brgl@bgdev.pl>, Pavel Machek <pavel@ucw.cz>, Lee Jones
> <lee@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, David S.
> Miller <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
> Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
> Wolfgang Grandegger <wg@grandegger.com>, Kalle Valo
> <kvalo@kernel.org>, Sebastian Reichel <sre@kernel.org>, Mark Brown
> <broonie@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> <linux-clk@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
> <linux-gpio@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
> <linux-leds@vger.kernel.org>, <linux-media@vger.kernel.org>,
> <netdev@vger.kernel.org>, <linux-can@vger.kernel.org>,
> <linux-wireless@vger.kernel.org>, <linux-pm@vger.kernel.org>,
> <alsa-devel@alsa-project.org>, <linux-usb@vger.kernel.org>
> 
> 
> SPI and I2C bus node names are expected to be "spi" or "i2c",
> respectively, with nothing else, a unit-address, or a '-N' index. A
> pattern of 'spi0' or 'i2c0' or similar has crept in. Fix all these
> cases. Mostly scripted with the following commands:
> 
> git grep -l '\si2c[0-9] {' Documentation/devicetree/ | xargs sed -i -e
> 's/i2c[0-9] {/i2c {/'
> git grep -l '\sspi[0-9] {' Documentation/devicetree/ | xargs sed -i -e
> 's/spi[0-9] {/spi {/'
> 
> With this, a few errors in examples were exposed and fixed.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Cc: Miguel Ojeda <ojeda@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: Guenter Roeck <groeck@chromium.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Lee Jones <lee@kernel.org>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Wolfgang Grandegger <wg@grandegger.com>
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-clk@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-i2c@vger.kernel.org
> Cc: linux-leds@vger.kernel.org
> Cc: linux-media@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-can@vger.kernel.org
> Cc: linux-wireless@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> ---
>  .../bindings/auxdisplay/holtek,ht16k33.yaml       |  2 +-

....

>  86 files changed, 110 insertions(+), 103 deletions(-)
> 
> diff --git 
> a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> index fc4873deb76f..286e726cd052 100644
> --- a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> +++ b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> @@ -72,7 +72,7 @@ examples:
>      #include <dt-bindings/interrupt-controller/irq.h>
>      #include <dt-bindings/input/input.h>
>      #include <dt-bindings/leds/common.h>
> -    i2c1 {
> +    i2c {
>              #address-cells = <1>;
>              #size-cells = <0>;

Acked-by: Robin van der Gracht <robin@protonic.nl>