Message-ID: <addaa95e4c2e840ac041efcedc99a235af90c6c1.camel@sipsolutions.net>
Subject: Re: [PATCH v8 1/5] mac80211_hwsim: add PMSR capability support
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Simon Horman <simon.horman@corigine.com>,
        Jaewan Kim <jaewan@google.com>
Cc:     gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, kernel-team@android.com, adelva@google.com
Date:   Mon, 06 Mar 2023 17:58:37 +0100
In-Reply-To: <ZAYa4oteaDVPGOLp@corigine.com>
References: <20230302160310.923349-1-jaewan@google.com>
         <20230302160310.923349-2-jaewan@google.com> <ZAYa4oteaDVPGOLp@corigine.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

>=20
> > @@ -3186,6 +3218,7 @@ struct hwsim_new_radio_params {
> >  	u32 *ciphers;
> >  	u8 n_ciphers;
> >  	bool mlo;
> > +	const struct cfg80211_pmsr_capabilities *pmsr_capa;
>=20
> nit: not related to this patch,
>      but there are lots of holes in hwsim_new_radio_params.
>      And, I think that all fields, other than the new pmsr_capa field,
>      could fit into one cacheline on x86_64.
>=20
>      I'm unsure if it is worth cleaning up or not.
>=20

Probably not. It's just a temporary thing there, I don't think we even
have it for longer than temporarily on the stack.

johannes