Date:   Mon, 6 Mar 2023 18:38:07 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Jaewan Kim <jaewan@google.com>, gregkh@linuxfoundation.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        kernel-team@android.com, adelva@google.com
Subject: Re: [PATCH v8 1/5] mac80211_hwsim: add PMSR capability support
Message-ID: <ZAYk/1g3Hz/UX7Ir@corigine.com>
References: <20230302160310.923349-1-jaewan@google.com>
 <20230302160310.923349-2-jaewan@google.com>
 <ZAYa4oteaDVPGOLp@corigine.com>
 <addaa95e4c2e840ac041efcedc99a235af90c6c1.camel@sipsolutions.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <addaa95e4c2e840ac041efcedc99a235af90c6c1.camel@sipsolutions.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0KaAUcua5vcI1VJ2B9EIi9rxGYDyBvJAq7e2lLys3eQdeirYW4WimKGAlXwU?=
 =?us-ascii?Q?6HeO5i4jWnbDTr6PYBa/KGjET8ioBIElKJ5CdP42aD0YLTpT4sauwvY5mhvC?=
 =?us-ascii?Q?wH0Bb9aF9RcXC631SiYBlxFupjAZ09LZXeHf3fiomE2236zI7KWxA42lUgoT?=
 =?us-ascii?Q?RVUqh7MzNjl3m/ooRwmYwgBJOly8ehx8hLK04MtlmFJFUDO0VLXoQXfoWPG8?=
 =?us-ascii?Q?Xv0qt95caLHQfYTsdNewpu6+AyVtCbq5m0nrEfQ0crBuLFYfvQDtIIKiyl2e?=
 =?us-ascii?Q?ZRYlHb9E426OgyX2x4q9jsRycL182sJpLH8iO6kmK95zcoiDYwDt9kGp0R5t?=
 =?us-ascii?Q?XjP08MuBI3satFpT0P+EB2ceKReVsLmb3TY5ZVuVLpJha7vXJpYeY1Pd35TO?=
 =?us-ascii?Q?hIE/cuA8nGBjurjyfa2jDcWChEWQM3bsq4jYlCAvnx9CwCA0GwXKLDUxMgR6?=
 =?us-ascii?Q?MV8oqk9mogC2Rj3tfvHkH13O/PPFiYSRdNTHc7yIR3vd3juJXXqudinnwLVP?=
 =?us-ascii?Q?LV+dn1QIkV53eGpQJ2D6bdFU8T1AVJsRvhVY+fGmmC8DbQ5bqWmVHKZdSp5j?=
 =?us-ascii?Q?RDXjqTAa2nK13sDoAkQBWA0W0wS3Fvyy/M/cq9yL+uNcZyLAPLeP7k2g0V8w?=
 =?us-ascii?Q?pcVkNJeUY0gT+SgU7BBsdFb6jAd5W490yLgkyhs/0SeJytWD7hGpYpP5ejFx?=
 =?us-ascii?Q?VRQf/AiUW6YlkKZDB6+joehNdR18ICYM2MPa1Wkj/s+Knw0GMaNUkofcELWC?=
 =?us-ascii?Q?ToYeJft8FoKijBwJfH7s6Dii5/by5wTWXeCU8ov53tDXlq6ejEyLsTW89PsS?=
 =?us-ascii?Q?6TOzlwyDIQTEZid5+Xyq9FK3Caejf+JdWiiDWIrabNcgNfGSnFj0dZtFlbwJ?=
 =?us-ascii?Q?Zd1gT1uo5q6P3pUSbCWjO4LUHy3mJ1fxTtHeEBXNn8fWpaj+/LyZHFeSAYkO?=
 =?us-ascii?Q?TfszwNWPPkc9tJ36xlGYBsgOhQC7MPEDJwcJGgcugjw5C6TkscBQdaRXQ32p?=
 =?us-ascii?Q?l/Pfka8L3ygCODT5Zk3trgA4moauQLyGTmB+de0owc0hQSpy7SmvQ0KFrNDj?=
 =?us-ascii?Q?eETQaKVbLxDM5If+++fSFmi+R+84nloCmRWZoZml1B86JNrvmNX4K2uC2tk5?=
 =?us-ascii?Q?UWAyUHUFvom31jOEbV+LQsNwqtUdqwNE6ydthRcOlOOVHOHRadZOSge/fSrV?=
 =?us-ascii?Q?J2kB0xbAt8T7i0XEQTsJp0qzbS15Hf/RA8WIDv/NVk0G9EwfE7OfvQ61bS03?=
 =?us-ascii?Q?1WtUbolU9u2Uu3r78bW59ps6KJAZicJxinC/L0JHm8Tc2tP4bximXZb0OuFX?=
 =?us-ascii?Q?vCu1emMDuT9ksXbBOnp4KswM9mekOWXL5GVyVdwCfE+CDf0WCHgHGeDGfZSH?=
 =?us-ascii?Q?s7TVnp2tXjs2fYP0ealM8PGN38SiAJ4DstHy41H5d3N+LArCLdxNkIk/DROE?=
 =?us-ascii?Q?kTEO3/WgNPDaExvj6rgfv46SVcN2u26t9Ep0mKfVTRpiuriHAztplrqCSOwU?=
 =?us-ascii?Q?9A5TfVVB864q+iCC2kFFrGwUtEUf3WZaKR1LNrml3EyX8JCXOkOdIhiXBMyL?=
 =?us-ascii?Q?sASeuyJnwIk5AwnEbdFQlW68Hy2zM4STEk0qsSlJ+G4L4OsANxZsvV64Vedi?=
 =?us-ascii?Q?QivKctnlHfBnnuMn+z54OyJh2EX8+J1qwxS0DYYEWkcq3mD8x47UU9z0K1ov?=
 =?us-ascii?Q?xD3IiA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d7557e9-29df-4b28-9150-08db1e69902f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 17:38:14.4671
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B35EFPici1t4jeKKNBT4kdatjvxa42Cey6g5l29Py3H6R/IFhhE7vLS53rLJvhhyn+YyvzLxCDs7mcq6T8pbYuuAAfpNsEyv2V8zidxHYeY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3699
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Mon, Mar 06, 2023 at 05:58:37PM +0100, Johannes Berg wrote:
> > 
> > > @@ -3186,6 +3218,7 @@ struct hwsim_new_radio_params {
> > >  	u32 *ciphers;
> > >  	u8 n_ciphers;
> > >  	bool mlo;
> > > +	const struct cfg80211_pmsr_capabilities *pmsr_capa;
> > 
> > nit: not related to this patch,
> >      but there are lots of holes in hwsim_new_radio_params.
> >      And, I think that all fields, other than the new pmsr_capa field,
> >      could fit into one cacheline on x86_64.
> > 
> >      I'm unsure if it is worth cleaning up or not.
> > 
> 
> Probably not. It's just a temporary thing there, I don't think we even
> have it for longer than temporarily on the stack.

Thanks, got it.