Message-ID: <582bea54cc5833137a2f8b7a375484b1656ed761.camel@sipsolutions.net>
Subject: Re: [PATCH v8 3/5] mac80211_hwsim: add PMSR request support via
 virtio
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Simon Horman <simon.horman@corigine.com>,
        Jaewan Kim <jaewan@google.com>
Cc:     gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, kernel-team@android.com, adelva@google.com
Date:   Mon, 06 Mar 2023 21:45:16 +0100
In-Reply-To: <ZAYe4oATHMdqi/H9@corigine.com>
References: <20230302160310.923349-1-jaewan@google.com>
         <20230302160310.923349-4-jaewan@google.com> <ZAYe4oATHMdqi/H9@corigine.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-03-06 at 18:12 +0100, Simon Horman wrote:
>=20
> > =20
> > +static int mac80211_hwsim_send_pmsr_ftm_request_peer(struct sk_buff *m=
sg,
> > +						     struct cfg80211_pmsr_ftm_request_peer *request)
> > +{
> > +	struct nlattr *ftm;
> > +
> > +	if (!request->requested)
> > +		return -EINVAL;
> > +
> > +	ftm =3D nla_nest_start(msg, NL80211_PMSR_TYPE_FTM);
> > +	if (!ftm)
> > +		return -ENOBUFS;
> > +
> > +	if (nla_put_u32(msg, NL80211_PMSR_FTM_REQ_ATTR_PREAMBLE, request->pre=
amble))
>=20
> nit: I suspect that you need to invoke nla_nest_cancel() in
>      error paths to unwind nla_nest_start() calls.

The entire message is discarded if that happens, I think? Doesn't seem
all that necessary in that case.

johannes