Date:   Mon, 6 Mar 2023 22:11:25 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Jaewan Kim <jaewan@google.com>, gregkh@linuxfoundation.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        kernel-team@android.com, adelva@google.com
Subject: Re: [PATCH v8 3/5] mac80211_hwsim: add PMSR request support via
 virtio
Message-ID: <ZAZW/VAIESfTgByW@corigine.com>
References: <20230302160310.923349-1-jaewan@google.com>
 <20230302160310.923349-4-jaewan@google.com>
 <ZAYe4oATHMdqi/H9@corigine.com>
 <582bea54cc5833137a2f8b7a375484b1656ed761.camel@sipsolutions.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <582bea54cc5833137a2f8b7a375484b1656ed761.camel@sipsolutions.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mM+jr9RrOWJp5qde9pzeew+l/eF2L1aic4qBpA4akBFuhW3nUwEfGOzs3fAp?=
 =?us-ascii?Q?VkzQ5ZqyTej1xM8j1Z8SWag8DarkxhWQ62u8DUGdexXL4Lm6E+LI+IIl+y8R?=
 =?us-ascii?Q?s48n2gyEvW9uqrP2Y22xF2Ideipu7YrpfDIf7iUzaR5IaSO3JOuSeW7AbBm4?=
 =?us-ascii?Q?ZTs3JcpSZbSBmremUssX3lzPL9bXsVsDDcXCQTGjLr5Yjpkyt/zAi05qy0fg?=
 =?us-ascii?Q?Yj9Z6Ga1zdoLFgd4bBiarsop3S6QIK1PSUzBoUJVF1wNIyZBpzIrdGs6IFgV?=
 =?us-ascii?Q?8puNUAW7b5zPLcbt2nKwSFaCNfNsPqstYnEIapzaRsnnfaAHPy5eMu2tU6pY?=
 =?us-ascii?Q?dCeFKk+FT8HtBZioawJYfBcREyXhd0qHb+44DLGzfgE5t+qnTr34XbW2v053?=
 =?us-ascii?Q?KEcavFD4ie6HZOJSzKvcaYZJumeP2Boj9evZxOBmZJ1TQEXdL8UxdunsiO5R?=
 =?us-ascii?Q?ul1DSKGGMiE+rmMQ9YwCp1VEICFzmfzDux6mEBRxJtd00KciY+i65gRtWmsw?=
 =?us-ascii?Q?2KxNk7MB1F12tC5a9jiig34cczOS111m+9zSV/5+MStMnn663SGUj2TcJius?=
 =?us-ascii?Q?Dmuo+pskf1cKhiGBwfr2cfYXhNC691UnmI9VwjZ2rCn+lOuCBTKHCPPs00Y6?=
 =?us-ascii?Q?rJAZd4plR/mDZAxeJEVcpHNBPcSxIyQ98pk1jXDlI7mywMwfCtdfdhZfmBVo?=
 =?us-ascii?Q?X1BnyY+al9mnHm98xcH84IlJnjooUxM2PUopyaYHZIP5xwZuPZgjKBzJrGA9?=
 =?us-ascii?Q?HomQEZoWVDYPrOJCpfvlXmhk6t29NdeinOHc0a/zxCRpY7E7yIiPDLt2hww8?=
 =?us-ascii?Q?bsN/10YudGmS4FXMgjyKmhngAO3bZAdOJpjmYTB3tX4JG52ZOclMwCBZaajH?=
 =?us-ascii?Q?WRBZzUlILyiyc0khJGtL86KAY2+Z/v66vqB6rQHdCSNvztAU8vxBjG9Zkg3z?=
 =?us-ascii?Q?xCZImg45co02/VclbkP0wPNR7lhaXDbFQtrKD0lV5Mquv3G5lCw3p3rNnwRe?=
 =?us-ascii?Q?xABqt7pFMaw66JBmFZ65rnHcWxrfBqJMxiiOruqFbtKkPz9HnLg7TjtH15U2?=
 =?us-ascii?Q?PXNs4pKq3C3oeS7djTWpVsWN2giRAvKWvIOxLwqSW93MddclUPbPU7Z1Jvo3?=
 =?us-ascii?Q?YLppLIuVICYiseSkCuKPGA5qEKTSfTMRIpBhVem4YiLbFhzjQ4e+1ApoW2Ac?=
 =?us-ascii?Q?9oWFHyWLh0BkSBOM3bN5h+oB771j4Cq7IAIYK9RyuKbD2TfWbzHtT1S4g+3Q?=
 =?us-ascii?Q?7sMXPxnlk2vM751oMWgsZ1TEmjpMFQsZJV8vgZQfrdLpMd+y19x6wqZ7ZV69?=
 =?us-ascii?Q?jQZ88mbL2l2cOQ+5Yfompr9t9gp0utYvTKdx7C12nThM+MP5gC3vTYeRqq/H?=
 =?us-ascii?Q?z9zjHqfSItA7yqL2YMGkMWya/P0BFz+i+Cj0wlfZYsQEDAS7dyfAG450aCDb?=
 =?us-ascii?Q?A+ZYzlx9wvSUR2Bz86gRnNrJsu/YFcqMuV55PBWKRAWobSdiZVcV/vVI0/22?=
 =?us-ascii?Q?zAJzp45yJGBuB9zDbdgV31HZ76vXYWoPe97DwPLRKkPAMm1/zFJLjUNVC1s6?=
 =?us-ascii?Q?53R/WCbXGaRNoMu4KhvzjJnwdQ883dUHHOYvYzLY7X1HOeTcetQwolYjyG8O?=
 =?us-ascii?Q?R44ORd9JkOLjUQAq+BBXWycPrLK1DMTaYPb/Ko8Lwz0OJ+lvHz9jMu7BeVe8?=
 =?us-ascii?Q?eza1Ug=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6294fc46-525b-4043-cc75-08db1e875c2e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 21:11:32.1545
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NjZxvDbdBBO3zSrpXkoLg96pWyYz5DrUoXSMKM6IgXchK57oRMfPkixip83ZLvkkaX+dMMZETUQAl0WajRnPaks1rVGkgSiF3VsNdXGxRYk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5790
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Mon, Mar 06, 2023 at 09:45:16PM +0100, Johannes Berg wrote:
> On Mon, 2023-03-06 at 18:12 +0100, Simon Horman wrote:
> > 
> > >  
> > > +static int mac80211_hwsim_send_pmsr_ftm_request_peer(struct sk_buff *msg,
> > > +						     struct cfg80211_pmsr_ftm_request_peer *request)
> > > +{
> > > +	struct nlattr *ftm;
> > > +
> > > +	if (!request->requested)
> > > +		return -EINVAL;
> > > +
> > > +	ftm = nla_nest_start(msg, NL80211_PMSR_TYPE_FTM);
> > > +	if (!ftm)
> > > +		return -ENOBUFS;
> > > +
> > > +	if (nla_put_u32(msg, NL80211_PMSR_FTM_REQ_ATTR_PREAMBLE, request->preamble))
> > 
> > nit: I suspect that you need to invoke nla_nest_cancel() in
> >      error paths to unwind nla_nest_start() calls.
> 
> The entire message is discarded if that happens, I think? Doesn't seem
> all that necessary in that case.

Thanks. I was wondering about that, but forgot to add it to my review message.