MIME-Version: 1.0
References: <20230201183201.14431-1-len.brown@intel.com> <167706207598.17049.13538001164844345072.kvalo@kernel.org>
In-Reply-To: <167706207598.17049.13538001164844345072.kvalo@kernel.org>
From:   Matthew Wang <matthewmwang@google.com>
Date:   Tue, 7 Mar 2023 16:56:27 -0800
Message-ID: <CAAooHFd4UPitENa76Dvqp3KZSKvwzcX+3mqbKFF4PEs-obKW5g@mail.gmail.com>
Subject: Re: wifi: ath11k: allow system suspend to survive ath11k
To:     Kalle Valo <kvalo@kernel.org>
Cc:     Len Brown <len.brown@intel.com>, rafael@kernel.org,
        kvalo@codeaurora.org, linux-pm@vger.kernel.org,
        linux-wireless@vger.kernel.org,
        Carl Huang <cjhuang@codeaurora.org>, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

I'm a bit of a kernel n00b here, but it's unclear to me that this is
the right thing to do and I just wanted to get some clarity. If the
ath11k device fails to suspend, my understanding is that it might
waste power attempting to talk to the host that's currently asleep.
Are we sure that ath11k can recover from ignored failures/skipped
teardown?


On Wed, Feb 22, 2023 at 2:34=E2=80=AFAM Kalle Valo <kvalo@kernel.org> wrote=
:
>
> Len Brown <len.brown@intel.com> wrote:
>
> > When ath11k runs into internal errors upon suspend,
> > it returns an error code to pci_pm_suspend, which
> > aborts the entire system suspend.
> >
> > The driver should not abort system suspend, but should
> > keep its internal errors to itself, and allow the system
> > to suspend.  Otherwise, a user can suspend a laptop
> > by closing the lid and sealing it into a case, assuming
> > that is will suspend, rather than heating up and draining
> > the battery when in transit.
> >
> > In practice, the ath11k device seems to have plenty of transient
> > errors, and subsequent suspend cycles after this failure
> > often succeed.
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=3D216968
> >
> > Fixes: d1b0c33850d29 ("ath11k: implement suspend for QCA6390 PCI device=
s")
> >
> > Signed-off-by: Len Brown <len.brown@intel.com>
> > Cc: stable@vger.kernel.org
>
> Patch applied to wireless.git, thanks.
>
> 7c15430822e7 wifi: ath11k: allow system suspend to survive ath11k
>
> --
> https://patchwork.kernel.org/project/linux-wireless/patch/20230201183201.=
14431-1-len.brown@intel.com/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa=
tches
>