Message-ID: <fb2c1994-3020-c3d4-0062-5f72018a9b0b@candelatech.com>
Date:   Wed, 8 Mar 2023 15:37:03 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH 2/2] wireless: mac80211: fix ath10k wave-2 in 80mhz mode
 in config_bw logic.
Content-Language: en-US
To:     linux-wireless@vger.kernel.org
References: <20230308232421.2672247-1-greearb@candelatech.com>
 <20230308232421.2672247-2-greearb@candelatech.com>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
In-Reply-To: <20230308232421.2672247-2-greearb@candelatech.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Please ignore this one, I sent the wrong patch.

On 3/8/23 15:24, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> It was complaining about the 'DISABLE_HE' flag mismatch,
> so ensure that if ifmgd has DISABLE_HE set, then 'flags'
> also will have that flag set.
> 
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>   net/mac80211/mlme.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 0efca23be69b..52c8f2770757 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -505,6 +505,10 @@ static int ieee80211_config_bw(struct ieee80211_link_data *link,
>   	    chandef.width != NL80211_CHAN_WIDTH_80P80)
>   		flags |= IEEE80211_CONN_DISABLE_80P80MHZ;
>   
> +	/* if ifmgd has HE disabled, then we cannot re-enable that here. */
> +	if (link->u.mgd.conn_flags & IEEE80211_STA_DISABLE_HE)
> +		flags |= IEEE80211_STA_DISABLE_HE;
> +
>   	if (cfg80211_chandef_identical(&chandef, &link->conf->chandef))
>   		return 0;
>   

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com