Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2F2AC7618E for ; Mon, 13 Mar 2023 14:55:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231504AbjCMOzV (ORCPT ); Mon, 13 Mar 2023 10:55:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231782AbjCMOzK (ORCPT ); Mon, 13 Mar 2023 10:55:10 -0400 Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61355199D9; Mon, 13 Mar 2023 07:54:51 -0700 (PDT) Received: from [192.168.108.81] (unknown [213.36.7.13]) (Authenticated sender: marc.w.gonzalez@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 405B72003ED; Mon, 13 Mar 2023 15:53:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1678719242; bh=UnHZBQTT9hhzAxrNCZK8DTtPY9z8YJna3Q7VPAED7GI=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=n/WRreEvMyHnd2toVT02RiQnuM2nVprMx1IRczJrzx1lca7yigeAvnPvdVbNNPPBH ndvqjYWGTmC4pm6APoO/14pWDUyctCiRFGtYtYcsB6LwAp/QSCnLHjpCpgm58rswKQ vh8j+Xa9nC5VyQG4+6dYmXuYVm3rNM/hqvqD9sft56+FEyQRehMhfr4nmSXRjpXMsv yVZw8uh7V4MCpZnXodj+ZMslff5P7ZNhu+zseqBvMtXnyH0X1PKX6Q7q+tw1C7a2Pz NL9lLeY2jPZjYAhoilpvGntAstBw+PgbLnlC9zrOn7L0wi+dFcxYKQA/JDIxyq1e/J J7VeIiqLCU+Jw== Message-ID: Date: Mon, 13 Mar 2023 15:53:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [RFC PATCH] brcmfmac: add 43751 SDIO ids and initialization Content-Language: en-US From: Marc Gonzalez To: Ulf Hansson Cc: Neil Armstrong , Arend van Spriel , Franky Lin , Hante Meuleman , Kalle Valo , Eric Dumazet , Pieter-Paul Giesberts , Alexander Prutskov , Joseph chuang , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Angus Ainslie , Pierre-Hugues Husson , linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org References: <05977cbb-8a8f-0a67-b4bd-b265dbb83280@free.fr> <895a3812-e490-cc40-0f8e-a88e166e8f24@linaro.org> <13676dcc-944f-cf3d-8adf-ee3d4e8fa699@free.fr> <0450e34e-7190-104c-832a-150f15f7c825@free.fr> <3d91a067-c9c3-6d71-11a7-1289ea67f109@free.fr> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 13/03/2023 15:41, Marc Gonzalez wrote: > NOTA BENE: for mmc1, in both runs, kernel probes 10 times and fails with: > > [ 1.265231] mmc_attach_sdio failed with -110 > [ 1.373006] mmc1: new HS200 MMC card at address 0001 > [ 1.377242] mmcblk1: mmc1:0001 SCA16G 14.7 GiB > [ 1.383718] mmcblk1boot0: mmc1:0001 SCA16G 4.00 MiB > [ 1.387257] mmcblk1boot1: mmc1:0001 SCA16G 4.00 MiB > [ 1.391912] mmcblk1rpmb: mmc1:0001 SCA16G 4.00 MiB, chardev (246:0) > > mmc_attach_sdio() fails but mmc_add_card() succeeds anyway...? > Confused. > mmc_attach_sdio() doesn't call mmc_add_card() if it exits prematurely. This might be because mmc1 and mmc2 are of "different nature". [ 2.083053] mmc2: new ultra high speed SDR50 SDIO card at address 0001 [ 2.093918] CPU: 1 PID: 35 Comm: kworker/1:1 Not tainted 6.2.0-rc8 #300 [ 2.100464] Hardware name: SEI Robotics SEI510 (DT) [ 2.105296] Workqueue: events_freezable mmc_rescan [ 2.110038] Call trace: [ 2.126856] mmc_add_card+0xfc/0x2d0 [ 2.130392] mmc_attach_sdio+0x22c/0x3c0 [ 2.134273] mmc_rescan+0x258/0x2f0 [ 2.137723] process_one_work+0x1cc/0x320 [ 2.141691] worker_thread+0x14c/0x450 [ 2.145399] kthread+0x10c/0x110 [ 2.148591] ret_from_fork+0x10/0x20 /* below message from call_driver_probe() getting ENODEV */ [ 2.152299] mmcblk: probe of mmc2:0001 rejects match -19 [ 2.176589] YO mmc1 [ 2.180263] YO mmc1 [ 2.183937] YO mmc1 [ 2.187621] YO mmc1 [ 2.191299] YO mmc1 [ 2.194972] YO mmc1 [ 2.198649] YO mmc1 [ 2.202326] YO mmc1 [ 2.206000] YO mmc1 [ 2.209674] YO mmc1 [ 2.209687] mmc_attach_sdio failed with -110 [ 2.318954] mmc1: new HS200 MMC card at address 0001 [ 2.322515] CPU: 1 PID: 20 Comm: kworker/1:0 Not tainted 6.2.0-rc8 #300 [ 2.329061] Hardware name: SEI Robotics SEI510 (DT) [ 2.333892] Workqueue: events_freezable mmc_rescan [ 2.338635] Call trace: [ 2.355453] mmc_add_card+0xfc/0x2d0 [ 2.358989] mmc_attach_mmc+0xf0/0x180 [ 2.362698] mmc_rescan+0x280/0x2f0 [ 2.366148] process_one_work+0x1cc/0x320 [ 2.370115] worker_thread+0x14c/0x450 [ 2.373824] kthread+0x10c/0x110 [ 2.377015] ret_from_fork+0x10/0x20 [ 2.381265] mmcblk1: mmc1:0001 SCA16G 14.7 GiB [ 2.389945] mmcblk1boot0: mmc1:0001 SCA16G 4.00 MiB [ 2.391199] mmcblk1boot1: mmc1:0001 SCA16G 4.00 MiB [ 2.395897] mmcblk1rpmb: mmc1:0001 SCA16G 4.00 MiB, chardev (246:0)