Date:   Mon, 13 Mar 2023 17:58:02 +0100
From:   Michal Kubiak <michal.kubiak@intel.com>
To:     Jaewan Kim <jaewan@google.com>
CC:     <gregkh@linuxfoundation.org>, <johannes@sipsolutions.net>,
        <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
        <kernel-team@android.com>, <adelva@google.com>
Subject: Re: [PATCH v9 2/5] wifi: nl80211: make nl80211_send_chandef
 non-static
Message-ID: <ZA9WGhHRqdZKBI7U@localhost.localdomain>
References: <20230313075326.3594869-1-jaewan@google.com>
 <20230313075326.3594869-3-jaewan@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230313075326.3594869-3-jaewan@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UmqvOmZFdCafFOeUInQiZkWdTza+DE0NxJdMndx6sbFskps0xFErH7wUshfc?=
 =?us-ascii?Q?NoJGaRnO20NkHrxItX3FXiosKy/8ky2mK/EvDJmpWARnTFKhyI6mQn90qlGo?=
 =?us-ascii?Q?D25zQn14bEgKRIXZ0UlTVM2Gga9oB0lLIZJ3JQzZHBJFxgQJBtaBss49tEZq?=
 =?us-ascii?Q?YK+O1gb/HTjgZoPLmaMqJ/54rJlDEzqWtmeQYWnLXsju3FNj6hrcYEjJPffI?=
 =?us-ascii?Q?7Lv2SUL+IszfniuuJ1x8jXfYMzuT+ZbAXWsJtLqcnImrz4XXpcHRug5VsWKO?=
 =?us-ascii?Q?ITjdXa2pnKaYxPpmLSTw3v3fmFZCwxl1iJgn+U9WECnLsj3SnlEutP9C0LNX?=
 =?us-ascii?Q?hoH6Om755FF06zhnZahbWfGHY2JnPVgBSrFbWDaYLxm/HPGDQX7/kiQ0rijJ?=
 =?us-ascii?Q?cignax0lG9rs/ktLF8D4/oGeEvpuK3NGg4ubg2UMQXZstuNC0nvjMooZXLV4?=
 =?us-ascii?Q?FemK74rX0o+fwJskkMebVkwDAWzfFkyCyUwS2O11P8iKe4qCeUohNl+zo4Fc?=
 =?us-ascii?Q?XyRdR8BQhqxYuZiXI4ucsT9xy25BqFMEd1ruy1d6ksadL6jPlwcffwXDe83D?=
 =?us-ascii?Q?Hu2vMxePqH9sDu8dE7kS4bAp/BVdLKj3fkCvEt0BapPScxbB4PlWpe/qPtJH?=
 =?us-ascii?Q?00kNaHCwK8IA1Si/VS6FnCtvqjLdldlMLjXzpKh/93mY6ZNeoGWiIEeULb76?=
 =?us-ascii?Q?GC+t6ak/mVy4AJHV7ZOUYb1oiB0z3+NFi8ovyHY2+JGZmNPkmAY59/eDBR59?=
 =?us-ascii?Q?M+p+zrBT2TWZPn1Gbpc5HojHTxAxdq5v4KCA5+B2uAsvmXTMuw2+gkG/gB0g?=
 =?us-ascii?Q?yA1j1ZKo0Mnyxmfdt9bQ9gpYANmWbGPoAZC+2V9dNphqwTzU6IYj7WrCaqvs?=
 =?us-ascii?Q?l5NRd8pos5CgQcGU+TlIxEdnrq8E/vdGeuszJFGNosRdwSpZxlWle6nsQRDy?=
 =?us-ascii?Q?vsM80z8wD+sb2OJpRGCZLEO6tfI+Irtc2hbjYXpVFRbdBCOc3paIREHo4vV0?=
 =?us-ascii?Q?Ry0nPGv4zL2MKtSipRTYYBjW+zQHXtuITz/hwUvBjK32omCrnfmQyxSX5HGO?=
 =?us-ascii?Q?6zO3NY+5TWBP4w8FamdZnxxeWkERmixBQUm2n6J2lBGSVnKLcAy+eDTrTjr+?=
 =?us-ascii?Q?jtsZYosDMOXWyOQGJSyVEnHyGtRAVLCSB8XvIc9xutvmv8I9ckCBEkNaQ1mF?=
 =?us-ascii?Q?k7RtWoRUsPQkcJ2SMhyekX+kGq2bC7ie9nYzluDlgDvdoN3rnRATpWYiv95+?=
 =?us-ascii?Q?nq88Z/bD2XCCuGmaHPUL6N8GMmlEtzHSrhQj2BiKPd2MP2jKKKScCdYvB1Ga?=
 =?us-ascii?Q?zmUoWm+HTWcbEc+0NficF2rZXsoOHRhNoZO5zRf3kEuuuHCzGE8mxeNCy8qa?=
 =?us-ascii?Q?7pouatXYBA55dYE86ORON5ECbms6GOH2cuutTZO9p5ZfKqSZ93ttyAie9KTb?=
 =?us-ascii?Q?CpdqloDJ2zISVN6U6Sc0jtHZCqppipqqBc3KHlfsLg3UG1+KcKOKDdTzQIei?=
 =?us-ascii?Q?HgWYpPQJ95cfjhv+Ax4M0JRljMUVlqfOBs1Ou7srXhBXI+ehAJrHYAGchU/d?=
 =?us-ascii?Q?taEJcweucc05gCAZYOC3aPzM4QJ+ZcT5K08nBrJRE9Nr+fUIGlu1Sq5XeNVG?=
 =?us-ascii?Q?gw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b5ac6b0e-475d-42d8-7269-08db23e41e87
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2937.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 16:58:07.6172
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k353RCso8qyCbXI0YfS83yfVVPhH5f9XBwDIq35vQfvwbN+eCt/2IE9Eh3Yd+1Rmvzald+SQAPL40DuB8BbN9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7504
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Mon, Mar 13, 2023 at 07:53:23AM +0000, Jaewan Kim wrote:
> Expose nl80211_send_chandef functionality for mac80211_hwsim or vendor
> netlink can use it where needed.
> 
> Signed-off-by: Jaewan Kim <jaewan@google.com>
> ---
> V8: Initial commit (split from other change)
> ---
>  include/net/cfg80211.h | 9 +++++++++
>  net/wireless/nl80211.c | 4 ++--
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index f115b2550309..bcce8e9e2aba 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h

Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>

> @@ -938,6 +938,15 @@ int cfg80211_chandef_dfs_required(struct wiphy *wiphy,
>  				  const struct cfg80211_chan_def *chandef,
>  				  enum nl80211_iftype iftype);
>  
> +/**
> + * nl80211_send_chandef - sends the channel definition.
> + * @msg: the msg to send channel definition
> + * @chandef: the channel definition to check
> + *
> + * Returns: 0 if sent the channel definition to msg, < 0 on error
> + **/
> +int nl80211_send_chandef(struct sk_buff *msg, const struct cfg80211_chan_def *chandef);
> +
>  /**
>   * ieee80211_chanwidth_rate_flags - return rate flags for channel width
>   * @width: the channel width of the channel
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 112b4bb009c8..1fd9e6545225 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -3756,8 +3756,7 @@ static int nl80211_set_wiphy(struct sk_buff *skb, struct genl_info *info)
>  	return result;
>  }
>  
> -static int nl80211_send_chandef(struct sk_buff *msg,
> -				const struct cfg80211_chan_def *chandef)
> +int nl80211_send_chandef(struct sk_buff *msg, const struct cfg80211_chan_def *chandef)
>  {
>  	if (WARN_ON(!cfg80211_chandef_valid(chandef)))
>  		return -EINVAL;
> @@ -3788,6 +3787,7 @@ static int nl80211_send_chandef(struct sk_buff *msg,
>  		return -ENOBUFS;
>  	return 0;
>  }
> +EXPORT_SYMBOL(nl80211_send_chandef);
>  
>  static int nl80211_send_iface(struct sk_buff *msg, u32 portid, u32 seq, int flags,
>  			      struct cfg80211_registered_device *rdev,
> -- 
> 2.40.0.rc1.284.g88254d51c5-goog
>