Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7448CC61DA4 for ; Wed, 15 Mar 2023 06:32:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230518AbjCOGcx (ORCPT ); Wed, 15 Mar 2023 02:32:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbjCOGcv (ORCPT ); Wed, 15 Mar 2023 02:32:51 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B71BD62853 for ; Tue, 14 Mar 2023 23:32:47 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id o12so71330796edb.9 for ; Tue, 14 Mar 2023 23:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678861966; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QvFKljKO0WMF10425trbTqfWVjsV5fmlF9IxkwLDpAQ=; b=qNA4JejxVNs9t+Gh7Hf+Qj5kfknpfiv/6cR6xDvH2K/IKalKT/Y3J0793KIx/D1NJY pgvNrTZQkGqGt/Z8XdiJtPBpl7+7aemYQgFNIax++hJFJbffoAtDQRcOL1adIBDoVyg3 DBq18A7g+37/8hCbK8jUigRLjJ2bhK+jw43wLT8e95fdTFSQZGCa1IWp4ATfX9o4SaeI K2QWaYlcePsZIv7z06WgfXykM197rcY2NpzEILKyouYsvzwnqLqQjjCCxsfhJeySGjzC kLIf502IyP3BMNVZjg7kF4Jek20Q69Ny619Yt4R1PqmnfM1WJ17kCRTkL4/HN7EmkpOa WQhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678861966; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QvFKljKO0WMF10425trbTqfWVjsV5fmlF9IxkwLDpAQ=; b=biE3PzEbgqkWXacWTOl7v9eCVbP2i+gA0XM4nLWvEr9ezk0d1QyHIp4bOo61HLJOZs ibqkjmgpypRCQDyj7EjVqOtsHJbfcEQ3RS0iZI50KTSnDpD405fGdDXARXIIJIonLJwT VzapaTKhDZPG/dlD7510oCzKFd7kqHSbbRTIq8imRb5r34khGIBzcNQ6F1jhcSZucy6d r4U+kppvHaHuRli6z2rId3HshJjXoziBwj8XPYH08M2qkMUSzWqRdzm2LmvBJpk+mvAQ vyHMtpKZ6EYpaCyHxZqZYSCuq3KK2sEO+uNiivM9q83o35ndH45/DKbd1ID6yD0ROtxC NijQ== X-Gm-Message-State: AO0yUKUw4RFav5gx6zHVvJQMAXD2d3ryWlk+14xviDV7v53HWDqlTsUR +OhPUcJQ8jn7RCGG5ZSW6KQd5w== X-Google-Smtp-Source: AK7set/Zh8cjRrDKfOLXp5lqghOjBaoH4KoRkWd6HaXgr8CUCFLcU31eQkh01dDJ/9XZZaJYSQzDoA== X-Received: by 2002:a17:906:60d2:b0:877:8a55:2a26 with SMTP id f18-20020a17090660d200b008778a552a26mr4596388ejk.60.1678861966182; Tue, 14 Mar 2023 23:32:46 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:940e:8615:37dc:c2bd? ([2a02:810d:15c0:828:940e:8615:37dc:c2bd]) by smtp.gmail.com with ESMTPSA id m22-20020a170906259600b008f883765c9asm2026303ejb.136.2023.03.14.23.32.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 23:32:45 -0700 (PDT) Message-ID: <57c42604-38b0-61ce-2fc4-2284fbb9d708@linaro.org> Date: Wed, 15 Mar 2023 07:32:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] p54spi: convert to devicetree To: Arnd Bergmann , Arnd Bergmann , Christian Lamparter , Kalle Valo Cc: Linus Walleij , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , Linux-OMAP , Tony Lindgren , Aaro Koskinen , Felipe Balbi , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Russell King , Dmitry Torokhov , Johannes Berg , linux-wireless@vger.kernel.org, Netdev , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230314163201.955689-1-arnd@kernel.org> <4ac809d2-3924-3839-479f-0b4be9f18a1f@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 14/03/2023 22:40, Arnd Bergmann wrote: >>> + >>> + power-gpios: >> >> If this is GPIO driving some power pin, then it should be >> "powerdown-gpios" (like in /bindings/gpio/gpio-consumer-common.yaml) > > As far as I can tell, it's the opposite: the gpio turns the power on > in 'high' state. I could make it GPIO_ACTIVE_LOW and call it powerdown, > if you think that's better, but I don't think that is how it was > meant. Whether this is active low or high, I think does not matter. If this is pin responsible to control the power, then we use the name "powerdown-gpios". Effectively powerup GPIO is the same as powerdown, just reversed. Best regards, Krzysztof