Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-221-gec32977366-fm-20230306.001-gec329773
Mime-Version: 1.0
Message-Id: <afee6a67-2406-4f52-99a2-ee7eb26e587b@app.fastmail.com>
In-Reply-To: <57c42604-38b0-61ce-2fc4-2284fbb9d708@linaro.org>
References: <20230314163201.955689-1-arnd@kernel.org>
 <4ac809d2-3924-3839-479f-0b4be9f18a1f@linaro.org>
 <e19fd8bc-5944-409d-a4a1-3a3d53691634@app.fastmail.com>
 <57c42604-38b0-61ce-2fc4-2284fbb9d708@linaro.org>
Date:   Wed, 15 Mar 2023 07:50:28 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
        "Arnd Bergmann" <arnd@kernel.org>,
        "Christian Lamparter" <chunkeey@googlemail.com>,
        "Kalle Valo" <kvalo@kernel.org>
Cc:     "Linus Walleij" <linus.walleij@linaro.org>,
        "Bartosz Golaszewski" <brgl@bgdev.pl>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux-OMAP <linux-omap@vger.kernel.org>,
        "Tony Lindgren" <tony@atomide.com>,
        "Aaro Koskinen" <aaro.koskinen@iki.fi>,
        "Felipe Balbi" <balbi@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        =?UTF-8?Q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>,
        "Russell King" <linux@armlinux.org.uk>,
        "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
        "Johannes Berg" <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] p54spi: convert to devicetree
Content-Type: text/plain
Precedence: bulk

On Wed, Mar 15, 2023, at 07:32, Krzysztof Kozlowski wrote:
> On 14/03/2023 22:40, Arnd Bergmann wrote:
>
>>>> +
>>>> +  power-gpios:
>>>
>>> If this is GPIO driving some power pin, then it should be
>>> "powerdown-gpios" (like in /bindings/gpio/gpio-consumer-common.yaml)
>> 
>> As far as I can tell, it's the opposite: the gpio turns the power on
>> in 'high' state. I could make it GPIO_ACTIVE_LOW and call it powerdown,
>> if you think that's better, but I don't think that is how it was
>> meant.
>
> Whether this is active low or high, I think does not matter. If this is
> pin responsible to control the power, then we use the name
> "powerdown-gpios". Effectively powerup GPIO is the same as powerdown,
> just reversed.

Ok, so should I make this GPIO_ACTIVE_LOW and adapt the patch to
call it powerdown in both the code and dt for consistency?

      Arnd