MIME-Version: 1.0
References: <CANnVG6=a3etRagG+RaSEH-b4_nfzxpEKffQtuMWrttrbgjunZQ@mail.gmail.com>
 <186e23b5668.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
 <CANnVG6kjWj02eEFv_OeLiRtjrJ6yn4EsELz_BtrzFHH15GNMLw@mail.gmail.com>
 <186e26dc0a8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
 <CANnVG6n-eqKUQnX_6wncmjG1kyVfhxqs2L82xYQpDmGq89eVAQ@mail.gmail.com> <186e4673718.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
In-Reply-To: <186e4673718.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
From:   Michael Stapelberg <michael+lkml@stapelberg.ch>
Date:   Wed, 15 Mar 2023 09:53:43 +0100
Message-ID: <CANnVG6kaGj1SVCqf2y3=Xj_N2G9j+-VhLDN4_WY_ywDswNkO3g@mail.gmail.com>
Subject: Re: wifi breakage due to commit "wifi: brcmfmac: add support for
 vendor-specific firmware api"
To:     Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc:     Kalle Valo <kvalo@kernel.org>,
        Franky Lin <franky.lin@broadcom.com>,
        Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hey Arend

On Wed, 15 Mar 2023 at 09:33, Arend Van Spriel
<arend.vanspriel@broadcom.com> wrote:
>
> On March 15, 2023 8:58:43 AM Michael Stapelberg
> <michael+lkml@stapelberg.ch> wrote:
>
> > Hey Arend
> >
> > Thanks for taking a look.
> >
> > The brcmfmac-wcc module is present on my installation, but I=E2=80=99m =
not
> > currently loading it.
> > (I only load brcmutil, then brcmfmac.)
> >
> > But, even if I load it, the wlan0 interface still doesn=E2=80=99t show =
up.
> >
> > In the modules.dep, I see that brcmfmac-wcc should be loaded after
> > brcmutil and brcmfmac.
> > Is that accurate?
>
> Yes. Actually brcmfmac loads brcmfmac-wcc by itself.

Hmm, when I run lsmod after booting, I don=E2=80=99t see it:

/tmp/breakglass1452371198 # lsmod
hci_uart 61440 0 - Live 0xffffba314a2cd000
btbcm 24576 1 hci_uart, Live 0xffffba314a2c6000
bluetooth 786432 3 hci_uart,btbcm, Live 0xffffba314a205000
brcmfmac 258048 0 - Live 0xffffba314a1c5000
brcmutil 20480 1 brcmfmac, Live 0xffffba314a1bf000
ecdh_generic 16384 1 bluetooth, Live 0xffffba314a1ba000
ecc 36864 1 ecdh_generic, Live 0xffffba314a1b0000
/tmp/breakglass1452371198 #

How does the =E2=80=9Cload by itself=E2=80=9D mechanism work?
Maybe I=E2=80=99m missing a userspace component for it.

Thanks

>
>
> > My installation is somewhat unusual in that I use a custom userland
> > (see https://gokrazy.org/).
>
> Bit tricky choice of name :-p I will check it out.
>
> Regards,
> Arend
>
> >
> > Thanks
> > Best regards
> > Michael
> >
> >
> > On Wed, 15 Mar 2023 at 00:21, Arend Van Spriel
> > <arend.vanspriel@broadcom.com> wrote:
> >>
> >> On March 14, 2023 11:49:05 PM Michael Stapelberg
> >> <michael+lkml@stapelberg.ch> wrote:
> >>
> >>> Of course, find it attached. Thanks.
> >>
> >> Strange. Could it be there is some build config needed to install the
> >> additional kernel modules (brcmfmac-wcc.ko, etc.) on RPi image?
> >>
> >> Regards,
> >> Arend
> >>
> >>>
> >>> On Tue, 14 Mar 2023 at 23:26, Arend Van Spriel
> >>> <arend.vanspriel@broadcom.com> wrote:
> >>>>
> >>>> On March 14, 2023 8:39:05 PM Michael Stapelberg
> >>>> <michael+lkml@stapelberg.ch> wrote:
> >>>>
> >>>>> Hey Arend
> >>>>>
> >>>>> I recently bisected a user-reported WiFi breakage on the Raspberry =
Pi
> >>>>> 3B+ to your commit
> >>>>> https://github.com/torvalds/linux/commit/d6a5c562214f26e442c8ec3ff1=
e28e16675d1bcf
> >>>>> https://lore.kernel.org/r/20221129135446.151065-4-arend.vanspriel@b=
roadcom.com
> >>>>>
> >>>>> On our end, the issue was reported here:
> >>>>> https://github.com/gokrazy/wifi/issues/3
> >>>>>
> >>>>> As of Linux 6.2.6, this seems to still be unfixed, so I wanted to
> >>>>> check in and see if you could take a look please?
> >>>>
> >>>> I have a suspicion, but can you provide the kernel .config file so I=
 can
> >>>> see if I am on the right track.
> >>>>
> >>>>> + brcmfmac: brcmf_fwvid_request_module: mod=3Dwcc: failed -2
> >>>>> + ieee80211 phy0: brcmf_attach: brcmf_fwvid_attach failed
> >>>>> + brcmfmac: brcmf_sdio_firmware_callback: brcmf_attach failed
> >>>>
> >>>> Regards,
> >>>> Arend
>
>
>