From:   Kalle Valo <kvalo@kernel.org>
To:     Alexander Wetzel <alexander@wetzel-home.de>
Cc:     johannes@sipsolutions.net, nbd@nbd.name,
        linux-wireless@vger.kernel.org, Thomas Mann <rauchwolke@gmx.net>,
        stable@vger.kernel.org
Subject: Re: [PATCH] wifi: mac80211: Serialize ieee80211_handle_wake_tx_queue()
References: <20230314211122.111688-1-alexander@wetzel-home.de>
Date:   Wed, 15 Mar 2023 18:47:15 +0200
In-Reply-To: <20230314211122.111688-1-alexander@wetzel-home.de> (Alexander
        Wetzel's message of "Tue, 14 Mar 2023 22:11:22 +0100")
Message-ID: <87fsa6vu5o.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Alexander Wetzel <alexander@wetzel-home.de> writes:

> ieee80211_handle_wake_tx_queue must not run concurrent multiple times.
> It calls ieee80211_txq_schedule_start() and the drivers migrated to iTXQ
> do not expect overlapping drv_tx() calls.
>
> This fixes 'c850e31f79f0 ("wifi: mac80211: add internal handler for
> wake_tx_queue")', which introduced ieee80211_handle_wake_tx_queue.
> Drivers started to use it with 'a790cc3a4fad ("wifi: mac80211: add
> wake_tx_queue callback to drivers")'.
> But only after fixing an independent bug with
> '4444bc2116ae ("wifi: mac80211: Proper mark iTXQs for resumption")'
> problematic concurrent calls really happened and exposed the initial
> issue.

This is cosmetics but the recommended way to refer to commits is:

  This fixes commit c850e31f79f0 ("wifi: mac80211: add internal handler
  for wake_tx_queue"), which introduced ieee80211_handle_wake_tx_queue....

More info:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches