Date:   Mon, 20 Mar 2023 13:34:30 +0100
From:   Johan Hovold <johan@kernel.org>
To:     Kalle Valo <kvalo@kernel.org>
Cc:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Johan Hovold <johan+linaro@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andy Gross <agross@kernel.org>, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp-crd: add wifi calibration
 variant
Message-ID: <ZBhS1rV2+9ivOVUi@hovoldconsulting.com>
References: <20230320104658.22186-1-johan+linaro@kernel.org>
 <20230320104658.22186-4-johan+linaro@kernel.org>
 <244a59c6-2dc0-83c7-07d2-6bae04022605@linaro.org>
 <ZBg7tA8NLDnjPp+k@hovoldconsulting.com>
 <ZBg+ixekH+Ou7jMd@hovoldconsulting.com>
 <87y1nrhazs.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87y1nrhazs.fsf@kernel.org>
Precedence: bulk

On Mon, Mar 20, 2023 at 02:18:31PM +0200, Kalle Valo wrote:
> Johan Hovold <johan@kernel.org> writes:

> >> > > +			qcom,ath11k-calibration-variant = "LE_X13S";
> >> > Intentional? Especially given Kalle's comment on bugzilla?
> >> 
> >> Yes, it is intentional. The corresponding calibration data allows the
> >> wifi to be used on the CRD. I measure 150 MBits/s which may a bit lower
> >> than expected, but it's better than having no wifi at all.
> >
> > I was going back and forth about mentioning this in the commit message
> > and we could off on this one until someone confirms that the
> > corresponding calibration data can (or should) be used for the X13s.

Hopefully clear from context, but that was supposed to say "CRD" and not
"X13s"...

> > Note that there is no other match for
> >
> > 	'bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=140'
> >
> > in the new board-2.bin.
> 
> If the device in question is something else than Lenovo X13s, I would
> prefer that the variant is not set. Just in case we need different board
> files for different models. It's easy to add aliases to board-2.bin.

The sc8280xp CRD is the Qualcomm "compute" reference design for this
platform and is very similar to the X13s but they are not identical.

For ath11k and wcn6855, the CRD I have reports a chip_id of 2 and
"hw2.0", while the X13s reports chip_id 18 and "hw2.1".

The new board-2.bin notably adds two entries that match these chip_ids
but with the variant specified as "LE_X13S" for both.

> I need to check internally what board file should be used for this CRD.
> If the speed is only 150 Mbit/s I suspect it needs a different board
> file.

Sounds good. Let's drop this one for now then.

Johan