Message-ID: <5e4ebc0244dfaafe8fe640458130a4527f43c728.camel@sipsolutions.net>
Subject: Re: [PATCH v2 0/4] Add AP power save support
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Maharaja Kennadyrajan <quic_mkenna@quicinc.com>,
        ath11k@lists.infradead.org
Cc:     linux-wireless@vger.kernel.org
Date:   Mon, 20 Mar 2023 18:04:57 +0100
In-Reply-To: <20230320164334.3325886-1-quic_mkenna@quicinc.com>
References: <20230320164334.3325886-1-quic_mkenna@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-03-20 at 22:13 +0530, Maharaja Kennadyrajan wrote:
> AP power save feature is enabled when the driver and hardware
> supports. If the driver suppots this feature then driver will
> advertise this flag SUPPORTS_AP_PS to enable the AP power save
> in mac80211.
>=20
> AP goes into the power save mode, if no stations are connected
> and it will come out of power save as and when any of the station
> associate to it. Also, during the power save tx chain mask is
> reduced to 1x1 until the any station connects with more than
> 1x1 chain mask.
>=20

All of that seems entirely transparent, similar to how mac80211 today
reduces bandwidth of the AP interface (min_def in a chandef) - what's
the point of doing all this infrastructure to make it configurable then?
Why not always have it, and perhaps make some debugfs to turn it off for
debugging/experiments?

johannes