Date:   Tue, 21 Mar 2023 14:28:26 +0100
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Ben Greear <greearb@candelatech.com>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] wireless: mt76: mt7921: Fix use-after-free in fw
 features query.
Message-ID: <ZBmw+uTa+CiV/KKJ@lore-desk>
References: <20230308175832.2394061-1-greearb@candelatech.com>
 <ZBl/vVj3wiaZl+du@lore-desk>
 <8f3fce81-dae7-9850-87ac-ed2b869c9dfd@candelatech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="18XES8yLT2FoOP51"
Content-Disposition: inline
In-Reply-To: <8f3fce81-dae7-9850-87ac-ed2b869c9dfd@candelatech.com>
Precedence: bulk


--18XES8yLT2FoOP51
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On 3/21/23 02:58, Lorenzo Bianconi wrote:
> > > From: Ben Greear <greearb@candelatech.com>
> > >=20
> > > Stop referencing 'features' memory after release_firmware is called.
> > >=20
> > > Fixes this crash:
> > >=20
> > > RIP: 0010:mt7921_check_offload_capability+0x17d
> > > mt7921_pci_probe+0xca/0x4b0
> > > ...
> > >=20
> > > Signed-off-by: Ben Greear <greearb@candelatech.com>
> > > ---
> > >   drivers/net/wireless/mediatek/mt76/mt7921/init.c | 11 +++++++++--
> > >   1 file changed, 9 insertions(+), 2 deletions(-)
> > >=20
> > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drive=
rs/net/wireless/mediatek/mt76/mt7921/init.c
> > > index 38d6563cb12f..d2bb8d02ce0a 100644
> > > --- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> > > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> > > @@ -165,12 +165,12 @@ mt7921_mac_init_band(struct mt7921_dev *dev, u8=
 band)
> > >   u8 mt7921_check_offload_capability(struct device *dev, const char *=
fw_wm)
> > >   {
> > > -	struct mt7921_fw_features *features =3D NULL;
> > >   	const struct mt76_connac2_fw_trailer *hdr;
> > >   	struct mt7921_realease_info *rel_info;
> > >   	const struct firmware *fw;
> > >   	int ret, i, offset =3D 0;
> > >   	const u8 *data, *end;
> > > +	u8 offload_caps =3D 0;
> > >   	ret =3D request_firmware(&fw, fw_wm, dev);
> > >   	if (ret)
> > > @@ -197,12 +197,19 @@ u8 mt7921_check_offload_capability(struct devic=
e *dev, const char *fw_wm)
> > >   	data +=3D sizeof(*rel_info);
> > >   	end =3D data + le16_to_cpu(rel_info->len);
> > > +	/* TODO:  This needs better sanity checking I think.
> > > +	 * Likely a corrupted firmware with bad rel_info->len, for instance,
> > > +	 * would blow this up.
> > > +	 */
> >=20
> > can you please repost dropping this comment?
>=20
> Why?  Looks to me like this portion of mtk driver logic assumes firmware =
is
> never corrupted on accident or on purpose.  It should be fixed at some po=
int.

even if this is a theoretical issue, this does not seem the right way to tr=
ack
it and it is not related to this patch.

Regards,
Lorenzo

>=20
> Thanks,
> Ben
>=20
> --=20
> Ben Greear <greearb@candelatech.com>
> Candela Technologies Inc  http://www.candelatech.com

--18XES8yLT2FoOP51
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZBmw+gAKCRA6cBh0uS2t
rIhWAQD0amDhnZ35j+epDOACpWA7rWsfLouUe5E6NONU+LFnyQEAsaMedSReQjMv
3wyagvSo3L3WSsC3lqHFDlzXOWvZWg8=
=pyIC
-----END PGP SIGNATURE-----

--18XES8yLT2FoOP51--