Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5821657rwl; Wed, 22 Mar 2023 02:51:32 -0700 (PDT) X-Google-Smtp-Source: AK7set8aojL/CwVPS3wrbkgXWDtGwUU6RbdvJeS/ijc7KVc/zFR3dKrwGs5JDHsFXb67TnejjblB X-Received: by 2002:a62:1c07:0:b0:626:2c3b:61b3 with SMTP id c7-20020a621c07000000b006262c3b61b3mr2583236pfc.26.1679478691911; Wed, 22 Mar 2023 02:51:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679478691; cv=none; d=google.com; s=arc-20160816; b=JryApdHU9eaWMmxw/ls4/3Rlq2Atv5+7tcv3y/7/YwhAo4fiBiflXPuLRoQHDmqCCd t1V8SgozNM5opYVWxAkZLjs1QrpmZruWVYZWRLDXZYsq4P7FqEI3uafxu9ofsRBSJdVT kaEmMXE7qNyF5ukJwgLsIQBXGQnRC1IvVhUTGZ/kzpJpiptEZNUj/2aoWDS/OLz2gPir g1AeCpv32gCvDfWafTkuVdfBC66uWW58qwHrM2SGDHhcgygNmGBtixCQF6K5skWvK9ql fbSZ9n9sdCWb1AnM575x4D1XkyiPIJlbMrScABjEONSPvk1Ucg/HOUw7b5J5jGBBNwc9 jQ0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=eOr5e5C/m8DlgLfQTqEWhjwV7+WPHizij6E/LBkN9PU=; b=OowCuce+fZMUmsAPTaYn+C/1sd2EeCNYf3BU/M7aahhf+RBtcyvaEiIAw6Zs3q8YjE 2tXZ5dvHbZOFCnA/lxW0ECkz6Wuu3us7kUzO4uFq0r765QbeuxojBpP6IRzWU36XDkW5 eqeOHwy3q7X6f0Rp8mj63OvNf2dwf3CSWRWSdlQ+79GuG61i3Ak+tci9XERXXXlrwFy0 P9+9LF2hQAvcXKsjjj27daJUyJOX/gq7yAZTL/NPzQk3j2YtqEHp8XBVgkc0y8Vn631O qNYfqN08lbCEscLEp/EkZFXzO/0ojGMFWg65A0rfKc8wPoi2jDgze96pUTcoFvGG+ilm G9fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=B89Bbu6J; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k17-20020a63d111000000b004fb924c6aefsi14597310pgg.243.2023.03.22.02.51.21; Wed, 22 Mar 2023 02:51:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=B89Bbu6J; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230350AbjCVJsv (ORCPT + 60 others); Wed, 22 Mar 2023 05:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231224AbjCVJs0 (ORCPT ); Wed, 22 Mar 2023 05:48:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CC75420F for ; Wed, 22 Mar 2023 02:47:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5537761FD1 for ; Wed, 22 Mar 2023 09:47:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 975CEC433EF; Wed, 22 Mar 2023 09:47:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679478452; bh=4HxVDzNfjJY6dkkmlEkbzo3As/3oTHbN33xG/hJluJA=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=B89Bbu6J/lWiotayPnDPHVfNeTGCqT/v8CLDJNXh7t4dXICawD5rAZJAuGXOzoczm IaUasWhyHp7kkhzPGlS/F9UrBi08wn+rfdsNyHeZZEJbgFUI+A0PiXYim98KDZqK3D ISfD64TML64uBjBYcbEuLltbGLKz7iAcLIXUUSZGgf9HEN+g0MkrlRzerluGATybXe VlBUEhqrkR5GyKYY+UwvIwS1t93oskYFpfC+o0RJySxERhhuji8gP6TakiAvKsIjX6 f6/xtRiQLKPuIPLBdGqY4LlGcdNxFJoutkHupcE5MRB37Yahq7+3f/dmN6dVr1iCd5 xXoiLQrzOOyzw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath11k: fix BUFFER_DONE read on monitor ring rx buffer From: Kalle Valo In-Reply-To: <20230309164434.32660-1-quic_hprem@quicinc.com> References: <20230309164434.32660-1-quic_hprem@quicinc.com> To: Harshitha Prem Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, Harshitha Prem , Sathishkumar Muruganandam User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167947844748.8844.13661658322623444104.kvalo@kernel.org> Date: Wed, 22 Mar 2023 09:47:31 +0000 (UTC) X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Harshitha Prem wrote: > Perform dma_sync_single_for_cpu() on monitor ring rx buffer before > reading BUFFER_DONE tag and do dma_unmap_single() only after device > had set BUFFER_DONE tag to the buffer. > > Also when BUFFER_DONE tag is not set, allow the buffer to get read > next time without freeing skb. > > This helps to fix AP+Monitor VAP with flood traffic scenario to see > monitor ring rx buffer overrun missing BUFFER_DONE tag to be set. > > Also remove redundant rx dma buf free performed on DP > rx_mon_status_refill_ring. > > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Sathishkumar Muruganandam > Signed-off-by: Harshitha Prem > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 68e93ac5a31d wifi: ath11k: fix BUFFER_DONE read on monitor ring rx buffer -- https://patchwork.kernel.org/project/linux-wireless/patch/20230309164434.32660-1-quic_hprem@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches