Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 19:31:38 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Tom Rix <trix@redhat.com>
Cc:     kvalo@kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, nathan@kernel.org,
        ndesaulniers@google.com, ath10k@lists.infradead.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] ath10k: remove unused ath10k_get_ring_byte function
Message-ID: <ZBybCkpexqml5hHF@corigine.com>
References: <20230322122855.2570417-1-trix@redhat.com>
 <ZBtnbgeW9T75ZXfv@corigine.com>
 <0b9f9c45-7e88-deda-46a6-8c7961878b83@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0b9f9c45-7e88-deda-46a6-8c7961878b83@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Qt0SEXzdk6SFGE3SljezVfP7Q+8J0JXPDU1uK4w555ItK1UsHTqcsayigDFu?=
 =?us-ascii?Q?7V+rREiTndwooCG4mEdk1xFLF6kX+ktWZpmnMEA8oeMM00PQlBUZSEkc3JCH?=
 =?us-ascii?Q?1xfeB/FE9PpGigKn0Tjpb5ED0AyXzFft0FB5MFrYrYnF/H/XZS2lx+cyUDr+?=
 =?us-ascii?Q?AaCvBOEOL/1xH2RwY5m2Ng4cqJZ8ItaBkX8kAqdI5SEERWoy3GJh9YuNxNLg?=
 =?us-ascii?Q?A/DyyZm1iaUf8ThY2dTqJHgt7jVlsWy3UW216qxQ2rAP3AGzXpbbUKn4Fwib?=
 =?us-ascii?Q?Cb41KQPoftFSe2lDW+96nlGM/VBagCzGnMfndR3XkbTSIeE5oSWb6/N3k5wx?=
 =?us-ascii?Q?sLv9tfpq6xI77Y679FXH0t1PF1wyGT73bEVD0JivC9SYNBj2yKWO3xu3CN4O?=
 =?us-ascii?Q?WKAJxEqPy6E28qjtMVMNZ4UgcmLC2BovcZOQIL+nkrU3H4XXH5m0jTbNWESJ?=
 =?us-ascii?Q?I8nza1v/a4upS8B6lzVI+EgE+ivFB2U5XxeIaSCdQ0J2ObnNhg7IINA6Dk6b?=
 =?us-ascii?Q?iIs+MdUJ2oU/b8gvOYakP+VF6NFmzDkOL3RoLO2VANPr0MFi23sZdQB93Bjz?=
 =?us-ascii?Q?cSwC6wXErUfMqhmMr0m5hO292CAdPqwx+CmgZSZzQNSGYcNM96buarA+q2w3?=
 =?us-ascii?Q?0ivkIVQj5Zmsi6at6Jm/TQPFjxpYMfWwi2zxYtnqnfpz92XqEHdANlyZJ2ay?=
 =?us-ascii?Q?4n3qfArP7kh/DbwKhX0/8Rz/Em/AZ1SUI1xdp7s+lhpJfqyLrSqwq6LjkHCe?=
 =?us-ascii?Q?rt71aoAvo41Xyblq30AU9tnTJfhtPbGSprrRxf04uZ4y99qUpnKjtt1fyQ+w?=
 =?us-ascii?Q?1rXuXzImPoZLNnPzfQzYiWvphHk74IY1Yy16oVRzI+D7L5zh/Dr7HQ4yzv3f?=
 =?us-ascii?Q?GcpnLceIBGIsnw1hHkbpaVah/zHmLE5PeX48w6l6k0tz9Rrbec3nh0u1cBeA?=
 =?us-ascii?Q?d2VESzAtDBlJVRfFWURpuLrzuLLy5bchMLSla2K2wvnjw+Z02dJN+TW/bYEr?=
 =?us-ascii?Q?SK4/Vz20akWqL/C6Qj3667RDLZIHDsx3EJn0UnMG4+ZmD/g19+Yi5uxpTtFz?=
 =?us-ascii?Q?mTbK3fE7fWLtO9+KR73b04kNjl216BbWn8JQKUjIOxJzvAbeGAsAgh50AHI6?=
 =?us-ascii?Q?y0jLQnQ161IOS9kPheEe/xtr2ogPAjUEOS0Ceaw3getXCnMpF7Bl0Rm1ssiw?=
 =?us-ascii?Q?7XYHbO6Yt4Vwp1SKx1VEMzi2r4TDciraLxiOyhskFcfoEI5mQryYfRfrSZbW?=
 =?us-ascii?Q?hEx5G/uRfOBxFZhu5TLf+LeK9xrR/uUnGjDqSvDuYTvMJFqngoa/SgN9Gxax?=
 =?us-ascii?Q?hF4Pk1QHYqKVG39TIUziTZwHcrIUehe7vAIjZ+/zI9rjpoZhRj7U+ePVum+I?=
 =?us-ascii?Q?PHyCUuNUdtPfo88i6edPNE5RCWGoO7PVEwh3XpjNYLwBudmoyGqxtZZ+bIxs?=
 =?us-ascii?Q?J8gpzYwMrbhm9GISciJf/VRlNvqWdfOHGeNoyJtJ/xvPk7U/cKRYiItfbi6b?=
 =?us-ascii?Q?n1zO4g17/nPt1C/MqV0yLhBt7Rl8mfJ+mM1BnkSHZH6J/FR1szvb15EEw1G6?=
 =?us-ascii?Q?8Z5Y1xjiX8fmvUmstaOAKQom7wrcOPbfLuZwwSccledumb9vtHjgrBydECFo?=
 =?us-ascii?Q?DIGY+5SPlqCvrLoDDQTg7wA13FYoqHfLvFRkfC+f7u6Qa6MmMh+8I5WzfO96?=
 =?us-ascii?Q?UKtE3g=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b4d2f70-5f0b-4218-8e5a-08db2bccda72
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 18:31:44.4614
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fGMDZxPTYrRzk7+pLZLMVpifim3zX0Rk1MW5YJ8oU8xJoa43biSMb7jjFB01bZYdRClNoTsAxwMRXCCgx3247gGevezCGtk6fzk8ij3HAn0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR13MB5149
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Thu, Mar 23, 2023 at 07:18:09AM -0700, Tom Rix wrote:
> 
> On 3/22/23 1:40 PM, Simon Horman wrote:
> > On Wed, Mar 22, 2023 at 08:28:55AM -0400, Tom Rix wrote:
> > > clang with W=1 reports
> > > drivers/net/wireless/ath/ath10k/ce.c:88:1: error:
> > >    unused function 'ath10k_get_ring_byte' [-Werror,-Wunused-function]
> > > ath10k_get_ring_byte(unsigned int offset,
> > > ^
> > > This function is not used so remove it.
> > > 
> > > Signed-off-by: Tom Rix <trix@redhat.com>
> > Hi Tom,
> > 
> > this looks good. But this patch applied, and with clang 11.0.2,
> > make CC=clang W=1 tells me:
> > 
> > drivers/net/wireless/ath/ath10k/ce.c:80:19: error: unused function 'shadow_dst_wr_ind_addr' [-Werror,-Wunused-function]
> > static inline u32 shadow_dst_wr_ind_addr(struct ath10k *ar,
> >                    ^
> > drivers/net/wireless/ath/ath10k/ce.c:434:20: error: unused function 'ath10k_ce_error_intr_enable' [-Werror,-Wunused-function]
> > static inline void ath10k_ce_error_intr_enable(struct ath10k *ar,
> >                     ^
> > Perhaps those functions should be removed too?
> 
> I believe these were removed with
> 
> c3ab8c9a296 ("wifi: ath10k: Remove the unused function
> shadow_dst_wr_ind_addr() and ath10k_ce_error_intr_enable()")

Sorry, my bad. You are correct.
Patch looks good to me (now).

Reviewed-by: Simon Horman <simon.horman@corigine.com>