Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp706774rwl; Fri, 24 Mar 2023 00:24:06 -0700 (PDT) X-Google-Smtp-Source: AK7set/GqdT5sF0HGcGeRADEFucKSxWtUU/15dvidk47QG5na2fkAKMccP+ZsbwQRi06HCmFrtWy X-Received: by 2002:a05:6a20:47e2:b0:da:adbf:7b96 with SMTP id ey34-20020a056a2047e200b000daadbf7b96mr1843846pzb.21.1679642646698; Fri, 24 Mar 2023 00:24:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679642646; cv=none; d=google.com; s=arc-20160816; b=s967QTVYeih0bH7/qaD2SOxKiM6RBLSg258DcYfMaGblg1n7H8TomILQMt65Gclp6O PvZsWWiCRiFzxWYE2KX2h28fCEuSqrVMfezRD1u6w4up+wH/LPvj2xwU1HgLAjPQLdn4 G15UD33rbwaaSnHWRmMaagbiqTj7PcPNrfW386g2L7HosRwnobq8XuW20989HFedoJa7 vCYkFifvKYHHz+QLAwbOH75CQI579CF07fQ5/Dgzkui6nrgisuZQTZaDu5rlN+SsM896 ljzvP9wS0BmwbSbwwKSiyF0IU85+1yr762eiGPbHfB+04wZTmpX210S4apRPGvIdyiv4 KJlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=yz1YuJSel4W/PbT838wGkE+Qf8AJspjoDl9c9B/BX6g=; b=PMXzyhr0Yk+2JLbQuOTZn0WDQ2sunM4/lm5IIyiMkvDa6znAekdoQKgFkQTYbvdtPu 51DG217GLV91AxejPznoCy1IKbW4TOoIl1Y5VhrYNSCVF1ogbsVk6IrAkM4y02DrZYCS yHbxGWrd1Z1wrVOjhdSbpj2iomUiEC84LCbjN5ZWYio1dsVbbZPph3tcN15wSLSz4iQz ty+B5CpL3Mr2wsoPpKl2q7I4iQRpSRf2MWXXQAH9BeIzMFl8D1UR1Uwkv79pOU+SkVt2 Ce3IxTpS3YNshwnnT+Pdcyu+4ImUN4zVAkoTkKm6gm/nxYX8dIRA9isYyc5oeZ9Rt/Ek x08Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KQGlvGpj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i22-20020a63d456000000b0050309caf60esi19066451pgj.750.2023.03.24.00.23.58; Fri, 24 Mar 2023 00:24:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KQGlvGpj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230133AbjCXHRV (ORCPT + 59 others); Fri, 24 Mar 2023 03:17:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231411AbjCXHRR (ORCPT ); Fri, 24 Mar 2023 03:17:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BEDE10248 for ; Fri, 24 Mar 2023 00:17:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3133662976 for ; Fri, 24 Mar 2023 07:17:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B671C4339B; Fri, 24 Mar 2023 07:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679642231; bh=aGztGcU7/fjAKFTZAFnUoTbI71Po/UtViDXqfGt4488=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KQGlvGpj6elZt0523wrFhTL92OMKKxsaOgo49VeIjmAkTHlD0n6d4ELMXy3mjt79S VWuBtihNt1UqBKdSGtFlQRgY1BG3L5tZQwwkvBmYjK1fVBt9/qHvJll2iyXaGetLLv TcVxRNoBvQBcPiRugkpXXCRXdAU8TZEjQLWHo6qcXldcP2E8MHSDiMiuoC3niAQY6H zhauftEKZL1BNT8jf7XRSBQAkGTxJuOL+Mhzytu0+sGNW4vXoCDWRjhWGsFUPLH0KB OKwG90BwSHY3CV/v/GiWL7XXRTf7//7kQ0C6SPEwp8WcmV3cPV1keky+mlktfaCoeq 6FqXhqIycm7Cg== From: Kalle Valo To: Felix Fietkau Cc: Lorenzo Bianconi , linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com, Ben Greear Subject: Re: [PATCH v3] wireless: mt76: mt7921: Fix use-after-free in fw features query. References: <51fd8f76494348aa9ecbf0abc471ebe47a983dfd.1679502607.git.lorenzo@kernel.org> Date: Fri, 24 Mar 2023 09:17:08 +0200 In-Reply-To: (Felix Fietkau's message of "Wed, 22 Mar 2023 21:58:36 +0100") Message-ID: <87zg82ty8b.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > On 22.03.23 17:37, Lorenzo Bianconi wrote: >> From: Ben Greear >> >> Stop referencing 'features' memory after release_firmware is called. >> >> Fixes this crash: >> >> RIP: 0010:mt7921_check_offload_capability+0x17d >> mt7921_pci_probe+0xca/0x4b0 >> ... >> >> Signed-off-by: Ben Greear >> Signed-off-by: Lorenzo Bianconi The title should have "wifi:", not "wireless:". > Acked-by: Felix Fietkau Felix, do you mean I should take this to wireless tree? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches