Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <829a59bc-dc57-9cda-7da9-8033ca419fd2@nbd.name>
Date:   Fri, 24 Mar 2023 11:19:30 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.0
Subject: Re: [PATCH v3] wireless: mt76: mt7921: Fix use-after-free in fw
 features query.
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>,
        linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com,
        Ben Greear <greearb@candelatech.com>
References: <51fd8f76494348aa9ecbf0abc471ebe47a983dfd.1679502607.git.lorenzo@kernel.org>
 <ff4c3a89-f3dc-2ae6-1b11-f2c46944e376@nbd.name> <87zg82ty8b.fsf@kernel.org>
From:   Felix Fietkau <nbd@nbd.name>
In-Reply-To: <87zg82ty8b.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 24.03.23 08:17, Kalle Valo wrote:
> Felix Fietkau <nbd@nbd.name> writes:
> 
>> On 22.03.23 17:37, Lorenzo Bianconi wrote:
>>> From: Ben Greear <greearb@candelatech.com>
>>>
>>> Stop referencing 'features' memory after release_firmware is called.
>>>
>>> Fixes this crash:
>>>
>>> RIP: 0010:mt7921_check_offload_capability+0x17d
>>> mt7921_pci_probe+0xca/0x4b0
>>> ...
>>>
>>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>>> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> 
> The title should have "wifi:", not "wireless:".
> 
>> Acked-by: Felix Fietkau <nbd@nbd.name>
> 
> Felix, do you mean I should take this to wireless tree?
Sure

- Felix