Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wifi: ath12k: incorrect channel survey dump
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20230320091208.25535-1-quic_hprem@quicinc.com>
References: <20230320091208.25535-1-quic_hprem@quicinc.com>
To:     Harshitha Prem <quic_hprem@quicinc.com>
Cc:     ath12k@lists.infradead.org, linux-wireless@vger.kernel.org,
        Harshitha Prem <quic_hprem@quicinc.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <167966937560.27260.15117945912260469719.kvalo@kernel.org>
Date:   Fri, 24 Mar 2023 14:49:37 +0000 (UTC)
Precedence: bulk

Harshitha Prem <quic_hprem@quicinc.com> wrote:

> When underlying hardware supports more than one band, then wiphy
> is aware of all the frequency bands present. Example, say
> wiphy0 is aware of 2 GHz, 5 GHz and 6 GHz band information.
> Hence, when an virtual AP interface is brought up in auto channel
> selection on each band. Survey is initiated from the userspace application
> for all the virtual AP interfaces simultaneously.
> 
> For survey dump collection, freq_to_idx() api is used to map the index of
> particular frequency to populate its survey. When the dump was collected,
> the index fetched was incorrect. Example, in case of multi-hardware,
> the index of channel 36 was reported as 14, because wiphy0 had index 0-13
> for 2 GHz channels, instead of 0 for that ar which resulted in invalid
> survey sent to userspace application.
> 
> The incorrect index was because of the mapping did not consider whether
> the freq band is present in its radio structure (ar) or not.
> 
> To handle this, the freq_to_idx() api should map index for the
> particular band in the ar structure.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Harshitha Prem <quic_hprem@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

25d165c49802 wifi: ath12k: incorrect channel survey dump

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230320091208.25535-1-quic_hprem@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches