Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 26 Mar 2023 10:11:26 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Wei Chen <harperchen1110@gmail.com>
Cc:     pkshih@realtek.com, kvalo@kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rtlwifi: fix incorrect error codes in
 rtl_debugfs_set_write_reg()
Message-ID: <ZB/+Lhyxg7Ur3/c7@corigine.com>
References: <20230326054217.93492-1-harperchen1110@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230326054217.93492-1-harperchen1110@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7jaJbmhUXs5n+lcCSLqhzNiqcVn/RFDqTp/dBF7KXHUVi7WSa2NpNc3frUme?=
 =?us-ascii?Q?8sWxaCoZR6lK6jnVrmqOLkxq9ud5TcVPJ7zxOPewDQ76Y6fI6SaEI3gB6Zn1?=
 =?us-ascii?Q?dclmCkUoORLreyZL9DjYhN1TW/8r31DhYUdqlZM3hEezCy7QLddjptQnZBzL?=
 =?us-ascii?Q?VD4aWDd3iire4TtRAZUAN7xsp0TxKULOs4RAUIHebWsgF64ZVa23lQ8MD4TV?=
 =?us-ascii?Q?3GNFxcD9rVP3mcD7mV8HRqZxgTsli7aLlmBPjku12kVIs68GsNFGpj+V+Lzc?=
 =?us-ascii?Q?Yev7vVLR4O7NsLx0GyptQJuMAk6ilLn+gZaffVMCF4hY1EvLs3ojtV2DRQ7k?=
 =?us-ascii?Q?qwS1csd3m9+0xwDj4FJn1ldkGpXNnSewPflSZWJALLfUjovyGKw3hDWHVYMy?=
 =?us-ascii?Q?8jEl96wa8gTKhijIqccjKVEAe97eBRFi41JQpTGAR6E5hkrRiiPxaU15+eaI?=
 =?us-ascii?Q?kOhP/DYfylw1O3CVZlKE3z7Zi6immz/DZwtBxYm5ukaIU6UhQqCkRZtgEZem?=
 =?us-ascii?Q?doO0HN9ooM4gmfSINRqHruA9bZK11TBm4IDvP+COf8FfL6AGm1gm7TvQ0Zt4?=
 =?us-ascii?Q?5mHPTOj91+bqUscPXcK6QUycw39wQ8FuHgSk3063SNDqRdl/xBanWykiZUYi?=
 =?us-ascii?Q?3JRYEAJb9PtXLyqy3xMmvSz3oGgO74KbxnikKtsH4FL7KP+iIgPKxyjitVd/?=
 =?us-ascii?Q?6uEOiohw7y9jFBe03NVI93IKk4JSe1HL7KfqHRpukVaTsp3PxeMchQ6y2uXn?=
 =?us-ascii?Q?pUbd+SoBuQXOZV2wksVfC5oiDqhU9KuR7rN2LEB2zjaDwYynBW4pg5wnRcCc?=
 =?us-ascii?Q?BSdX5L+8KYYd9P/2t12M+UMl95sQg6KzVFffWGp6uKpXFoCU/YoLymI7/9Ff?=
 =?us-ascii?Q?q+Z5EAxxtX3rEMZwy85mmQLsXKUgXRsbH/Kpk0XfTFVvhHrSX/53LeEifvIm?=
 =?us-ascii?Q?onhtK0UyWOsMQMoFu68Eh57f0KXBEYb6QnHGeE0Pxop23qQwBHeH+dL92zQE?=
 =?us-ascii?Q?hPIZ1hn0FrjeeJeJmrBswUm0161eVCAoW/EKQ8ioCtS6wADLesuuhkFA1EsO?=
 =?us-ascii?Q?Snl8GhKK9dJ83VdgvQijhhFIy4WkAdzSHe/NPSzG+K2IX5Nt/J0ecj2xSZQa?=
 =?us-ascii?Q?ZKzTYIw0jpBW3D2GQLrtKUTZs+/i4+iUOyle60FHP1Z2lMGTGs7VzVU9iaK8?=
 =?us-ascii?Q?tLBYY8TngyWkiVeRMZKEEGIE47ZIh7O7oSQal1tx6ONXsaPuyfwv8Hvw3k7o?=
 =?us-ascii?Q?lowu5ZxoRJS3AzKt6USm4xqYykcUIY7rPj1o3bO8J93TJGVYzhsIzKIOk8eB?=
 =?us-ascii?Q?iQp+pjVBYuZj8ghQ8bWAXtzHvcw+23rj1SxRztISmpFKsAgqiXMReWiP2Dtq?=
 =?us-ascii?Q?Yp+GH821zKEtyE8/MNtlMgdzOCP83tSGF8DOlS7BsO1/CojM3zzVkpSUz+p/?=
 =?us-ascii?Q?xhDzKuqzeZThcdQ97N9c5MXhEsxbewe3uhlwxay8lO2yFFd7LlxQINnn9lli?=
 =?us-ascii?Q?c0wRxjFimU+HFv33wPWjG3P4Y7qsE1ib2hZOKUDhPPesO+l0bnmyQigTncAl?=
 =?us-ascii?Q?b1nsk1VB4hmM+GfiGqQKTmv9qLKK2v7spSKg94RsaEEeholQB/Tapng74xxu?=
 =?us-ascii?Q?c71rzVPY0ax80J3a6rcJVjuAL/xMHZDftkgzsyN2EQLMZBxKdlWheuAkiWTj?=
 =?us-ascii?Q?aCvpgQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 508d0550-3f15-44b2-8f5b-08db2dd1b607
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2023 08:11:33.0352
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kN3G4+cZcVhKU/ZwF1vmPXOGT/5kNHIZND5PoqZ3u48zwrXtr3pu4JjOJm9HUZ+fOtNmTJkRbjTsGKmw7WfNvMKfRvAA2Fyd+pTsJc47X0E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5665
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Sun, Mar 26, 2023 at 05:42:17AM +0000, Wei Chen wrote:
> If there is a failure during copy_from_user or user-provided data buffer is
> invalid, rtl_debugfs_set_write_reg should return negative error code instead
> of a positive value count.
> 
> Fix this bug by returning correct error code. Moreover, the check of buffer
> against null is removed since it will be handled by copy_from_user.
> 
> Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
> Signed-off-by: Wei Chen <harperchen1110@gmail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>