Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1867540rwl; Sun, 26 Mar 2023 10:36:25 -0700 (PDT) X-Google-Smtp-Source: AK7set/Npn5HXRc1LVaTBl6r0XjFbNtx+Ntr9Kpw8QhPUqhydS3XxVn3W1PA339ADjPn8KFc+ndI X-Received: by 2002:a17:906:24cb:b0:930:8590:95ef with SMTP id f11-20020a17090624cb00b00930859095efmr16480585ejb.18.1679852185620; Sun, 26 Mar 2023 10:36:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679852185; cv=none; d=google.com; s=arc-20160816; b=IcDkzKbRPqQwlTfbwwYCrTe1fDQ3J7MzfUnWDRlJAQy5tlQW6AzODAH3gXBLr62UM/ lhDk6/j/qvssuSqeiqaa1BGNfCxzpBbIamOH8rBRvTOqC/U+bx+0sLG5/gJEf8LHf5id rzAP3ZUZRZMKNadhCPQ1vnswM5/+RHF5fIpF7nqkKeAS4EOMxPMESCJVciEl9LFhX5j+ E7jEKz2dw2PgP3l1lZitjhOEr1cY336m/o9faniWwM+DGwnjzGmlL1SNNqgUselQMg64 +1/9xex1dcb28kEz0JxELbnWM0tt6kNJeAinMmIb042zF5UdCxYXyhvnqPX9svInNfRL u/0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:sender:dkim-signature; bh=kMIdTPrzs9W2bcOisGTJ32C4tZONe5VcnIYDts13aIw=; b=cxM8cpFa8/vd71DP8ppgVLVkiIJN9vwy5pz53RqFwMpgds1BeJc8j639h53k3zfeXc iOWs2Sx9KA5boQnPwO6nboJFHWFqtwY/PR4SYxWMzuUb7RQTGD6/38XGa8rLcIG6SJZy onMPqgrVDShxDcyvzcd7hDojteTQGxC/+dGkEae3fkDURKD2VvC4clCc4NF2jYrBMkAo Rh5bewcNzAapGaACWRgeNFEY1vMo5Xhj/fOoGzljZkei0T9nyfnY2ZJO/e0u2mdC4CUN vv/v9l5bGnbMqbsOs/PxH/hqP2bvTmFPZEJH56Yh31zg+mXBI59r43m2oalbjdBqcqI+ n/LQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=nqNPvS2v; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t6-20020a05640203c600b004fca8e615f0si19979780edw.609.2023.03.26.10.36.06; Sun, 26 Mar 2023 10:36:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=nqNPvS2v; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230206AbjCZRc6 (ORCPT + 59 others); Sun, 26 Mar 2023 13:32:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229596AbjCZRc5 (ORCPT ); Sun, 26 Mar 2023 13:32:57 -0400 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3076E49D2; Sun, 26 Mar 2023 10:32:55 -0700 (PDT) Received: by mail-oi1-x234.google.com with SMTP id bf30so4713352oib.12; Sun, 26 Mar 2023 10:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679851974; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=kMIdTPrzs9W2bcOisGTJ32C4tZONe5VcnIYDts13aIw=; b=nqNPvS2vEQB9efoFo76JN7ONcu10HLvy2l6zDGCpZmhWoP3oDJITiKYFyR2UA6ylZX awrzoBNXSNjmAOOgckqCsw0ZF2HdzXbWe8jpW8/tJzbX6HVqLQnEU6u5J7FBZDLjksTv BSGEGgpIJQG7+N3d3OrQnCJVSBRFko45xnzAtvWoxcgJWPK1mqFUtl7lmknTkOeCxsAB LzpNO6MVG2bjmWGmYpC6Dx1iUbxzFZgzczeJvoy6K+V1tDUSQWBJP6nj1H9JzhgbRUDa EPGh7KEUD+CouiOeFE/Xh4H+RQ2sJKFk39vU8oUzS0MC6ZEk8KJSU+ewb7N802+fSqt0 8uyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679851974; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kMIdTPrzs9W2bcOisGTJ32C4tZONe5VcnIYDts13aIw=; b=toRsyzO4eFcPJmz70an2qLAnzIB2dPo3tIjY7DU9YtckfZkQyiLAMF48sWpHaMaMFd aA0shaR6xsj1XiQ91kXcUkWFtiP1OWhrbvPtvng2JyZn7j6782lH2UT1qvH4XKCphcan z5d3OttLyPEd+Pw0fV6aiED9UGmFFM1ZOJxc6brPzfdpAPhQaB6CTqMzY7ifkjO6Rf2n fKZJAKjc6Ror4GNG+AqrPVLQfbz/nsQHketWNr9xZMrxBDLQGDU0a3XJns2K6OkwfAD1 MZszRGzl/ikIed+cziTob1ceM+tcPfx2wt3JR8Y/M19HbSUrHZYwmifEGEWZ7TBeYg43 H0nQ== X-Gm-Message-State: AO0yUKVNSOffS6XUnvd5E1cEmuCJ6S83Ulf687DaAR7x1XbReBsfHrWF ZgcxUoGhaIEDjWmO4mxGYS8= X-Received: by 2002:a05:6808:15a7:b0:386:e073:6996 with SMTP id t39-20020a05680815a700b00386e0736996mr5472851oiw.26.1679851974518; Sun, 26 Mar 2023 10:32:54 -0700 (PDT) Received: from [192.168.1.204] ([216.130.59.33]) by smtp.gmail.com with ESMTPSA id i206-20020acaead7000000b003874e6dfeefsm4607368oih.37.2023.03.26.10.32.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Mar 2023 10:32:54 -0700 (PDT) Sender: Larry Finger Message-ID: <307ebdbb-1b0f-43df-04b1-a2275adcee72@lwfinger.net> Date: Sun, 26 Mar 2023 12:32:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] wireless: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_rfreg() Content-Language: en-US To: Simon Horman , Wei Chen Cc: pkshih@realtek.com, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230325083429.3571917-1-harperchen1110@gmail.com> From: Larry Finger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 3/26/23 03:03, Simon Horman wrote: > On Sun, Mar 26, 2023 at 01:47:51PM +0800, Wei Chen wrote: >> Dear Simon, >> >> Thanks for the advice and review. I have sent the second version of the patch. >> >> Besides, rtl_debugfs_set_write_reg also suffers from the incorrect >> error code problem. I also sent v2 of the corresponding patch. Hope >> there is no confusion between these two patches. > > Thanks. I now see there are two similar but different patches. My bad. Avoid all such misunderstandings by making a patch set. Larry