Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a20e39027ca0b89cae2259d35ff19d03c3c6951a.camel@sipsolutions.net>
Subject: Re: [PATCH 24/27] wifi: mac80211: implement link switching
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Wen Gong <quic_wgong@quicinc.com>, linux-wireless@vger.kernel.org
Cc:     ath11k@lists.infradead.org, ath12k@lists.infradead.org
Date:   Mon, 27 Mar 2023 11:04:23 +0200
In-Reply-To: <31b91fad-bd14-b6e1-8abe-fceb66085ecb@quicinc.com>
References: <20220902141259.377789-1-johannes@sipsolutions.net>
         <20220902161143.d99dfbe65c90.I92385ba882ec984a9a2ad18293173436657e82aa@changeid>
         <ca5177fe-3b9f-2309-9afd-1d5e827540f7@quicinc.com>
         <50719d34bc48d816d00b56d3d9efdb59e3e51a16.camel@sipsolutions.net>
         <31b91fad-bd14-b6e1-8abe-fceb66085ecb@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-03-27 at 16:40 +0800, Wen Gong wrote:
> >=20
> > > > +	for_each_set_bit(link_id, &add, IEEE80211_MLD_MAX_NUM_LINKS) {
> > > > +		struct ieee80211_link_data *link;
> > > > +
> > > > +		link =3D sdata_dereference(sdata->link[link_id], sdata);
> > > > +
> > > > +		ret =3D ieee80211_link_use_channel(link, &link->conf->chandef,
> > > > +						 IEEE80211_CHANCTX_SHARED);
> > > For the 1st link of MLO connection/NON-MLO connetion, ieee80211_link_=
use_channel() is called before drv_change_sta_link(),
> > > And now it is after drv_change_sta_link(), May I know is it also has =
some design here?
> > Hmm, probably not really, at least I don't remember anything about that=
.
> >=20
> > Not sure it makes a huge difference? But I suppose we could change it, =
I
> > don't really see why not either.
> Not huge difference, I have made little change in lower-driver to match=
=20
> that. So it is OK now.

OK. Still maybe we should change it for consistency? I can try that
later with our driver.

johannes