Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp210692rwl; Wed, 29 Mar 2023 00:08:49 -0700 (PDT) X-Google-Smtp-Source: AKy350Y3jxLoups4TDs2YFGb9/3W2uFgVgFabfcqCfwo2SAwpgftmJZvZ2qyyMqFK6mlmVQ1wFoo X-Received: by 2002:a17:903:230d:b0:1a1:9787:507d with SMTP id d13-20020a170903230d00b001a19787507dmr1498843plh.3.1680073729191; Wed, 29 Mar 2023 00:08:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680073729; cv=none; d=google.com; s=arc-20160816; b=wWSrHw+rQDTuwS5nFe/lLb+JofJnjA88IEisw7rcgdEx/vdOcs7GRpOHwIX+nRYTUt VwNi0hVvpRim59Va2AS9J8hkbe4iafdPRxNQrJaFpE8HIRj2Wt0rteoBpU2/qFHrDDKH lfXf4AaA8QcgpVcAgcfT6oNvRcL5iMsey8kWrQ39xj/lhPFEEfZvgJ+BAkYgzJXcfMxs ZkNJqjQAGdOiXNC9dZYHHt78aFPHaRc8K9MP1WsoCzxZLpSHdhFDe8OJHtvTCi8cn1qj dX5WhWaRKC5PjM3SmF0Ohi6X7YbPoS8EswdH7hWrjCVO864/WZS9NC1UFcp5NRQbMjea U2PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3//C3KJqK5RFL2V9ILp+fgTszASusxT9VUtl9y5hhoM=; b=1GDUM4tFEWsIfm4siYl+M2UrTcClyPSCNYIqPHC2ObxPTpX+wUD4L3HkYV5ik5QFfQ tfCCEXue2vAqTsOgFuO2R1hWC4MCi5Y5I6yNz4U0PNTc3HcBhFuj0H8EHwumH/DqQaoc JQwUI3Eq3+aAwdSRebTXi3SnxvICUjE0hvS4yjGYCgBDIbl4JaD9ohzvVgKI6JRL+9oi RmGVhry3Bs7EShxYN8xh4JWy9wgIxKK/aejsKBd1twBp1rGWJIb01I2nm81F0A2kWVKg gyTki3PtcCaQsA+M5+ifmuEbcKlU+AavXESMP2sP8UYfvbJAbnTaq+EAX9rmx6HlY7Zr LnNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=k5YiDDIa; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a7-20020a170902ecc700b001a1c005bd39si27468168plh.97.2023.03.29.00.08.42; Wed, 29 Mar 2023 00:08:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=k5YiDDIa; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229632AbjC2HHX (ORCPT + 60 others); Wed, 29 Mar 2023 03:07:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229791AbjC2HHT (ORCPT ); Wed, 29 Mar 2023 03:07:19 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C836340DC for ; Wed, 29 Mar 2023 00:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680073627; x=1711609627; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=n3Y+x4SDdtN7RueS3Alov5U7wwsPeMJjRdkFWNotdfE=; b=k5YiDDIaogC/cLk/5ZWaMgCNsZpM+q3XDTlWxpzIqAoWSgx2v0m1iyg5 ZGdzYlQXJYr1temywfET+YYK8WYm9hUMbiQvXSF913eJSPiJKcCYrHqNs xjYauvxjqq3EEJ2rxe3V41do20yzm/VmZC8O59X43yVJdTkFnlEusJpM/ Q4hbchFig+5rjtK1SVvaUsIprntHiWzBvennVDUjL5V3Y/AxREv7TdZOU 9c9LcwMSjDn2Y4O6bB/2AaU+xpVzc32D/60pknYOyRoDgOITiStD/JWGF UTvw5aTJwaCIgR9gmHMESvJXnJ8I3IN2sl83+DT8svbsKkqEYJme1Hsl3 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10663"; a="320450795" X-IronPort-AV: E=Sophos;i="5.98,300,1673942400"; d="scan'208";a="320450795" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2023 00:06:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10663"; a="795111303" X-IronPort-AV: E=Sophos;i="5.98,300,1673942400"; d="scan'208";a="795111303" Received: from sfrank1-mobl1.ger.corp.intel.com (HELO ggreenma-mobl2.intel.com) ([10.214.228.42]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2023 00:06:14 -0700 From: gregory.greenman@intel.com To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Shaul Triebitz , Gregory Greenman Subject: [PATCH 11/34] wifi: iwlwifi: mvm: use the link sta address Date: Wed, 29 Mar 2023 10:05:17 +0300 Message-Id: <20230329100039.03ab287da0ae.I88fb5ab4e3ea9c886a3fac7ce09c4791469c3c8e@changeid> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230329070540.2739372-1-gregory.greenman@intel.com> References: <20230329070540.2739372-1-gregory.greenman@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Shaul Triebitz Replace the deflink.addr with the proper link address for setting the peer_link_address in the station command. For a non-MLD station, it will be the deflink. Signed-off-by: Shaul Triebitz Signed-off-by: Gregory Greenman --- drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c index da9d2cefa509..c877c94dd1d6 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c @@ -399,8 +399,7 @@ static int iwl_mvm_mld_cfg_sta(struct iwl_mvm *mvm, struct ieee80211_sta *sta, cmd.link_id = cpu_to_le32(link_info->fw_link_id); memcpy(&cmd.peer_mld_address, sta->addr, ETH_ALEN); - /* FIXME: use the correct link */ - memcpy(&cmd.peer_link_address, sta->deflink.addr, ETH_ALEN); + memcpy(&cmd.peer_link_address, link_sta->addr, ETH_ALEN); if (mvm_sta->sta_state >= IEEE80211_STA_ASSOC) cmd.assoc_id = cpu_to_le32(sta->aid); -- 2.38.1