Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <78fc12945f0f4ed90836e9031fd18d95a8c473a8.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: mac80211: Initialize EWMA fail avg to 1
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Karthik M <quic_karm@quicinc.com>
Cc:     linux-wireless@vger.kernel.org,
        Tamizh Chelvam Raja <quic_tamizhr@quicinc.com>
Date:   Thu, 30 Mar 2023 12:06:29 +0200
In-Reply-To: <20230317144432.10477-1-quic_karm@quicinc.com>
References: <20230317144432.10477-1-quic_karm@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-03-17 at 20:14 +0530, Karthik M wrote:
> If the average value has been rounded to 0 (success),
> reset it to the smallest nonzero value (similarly to the initialization) =
to
> avoid a case where a single failure would result in an average value
> that goes beyond the threshold value of 95.

What does 95 have to do with it?

Also the whole commit message doesn't even mention mesh a single time.


> Signed-off-by: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com>
> Signed-off-by: Karthik M <quic_karm@quicinc.com>
> ---
>  net/mac80211/mesh_hwmp.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>=20
> diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
> index 9b1ce7c3925a..e9fcaff9cc7e 100644
> --- a/net/mac80211/mesh_hwmp.c
> +++ b/net/mac80211/mesh_hwmp.c
> @@ -298,10 +298,21 @@ void ieee80211s_update_metric(struct ieee80211_loca=
l *local,
>  {
>  	struct ieee80211_tx_info *txinfo =3D st->info;
>  	int failed;
> +	u32 fail_avg;
>  	struct rate_info rinfo;
> =20
>  	failed =3D !(txinfo->flags & IEEE80211_TX_STAT_ACK);
> =20
> +	fail_avg =3D ewma_mesh_fail_avg_read(&sta->mesh->fail_avg);
> +	if (!fail_avg) {
> +		/* If the average value has been rounded to 0 (success),=20
> +		 * reset it to the smallest nonzero value (similarly to=20
> +		 * the initialization) to avoid a case where a single=20
> +		 * failure would result in an average value that goes=20
> +		 * beyond the threshold value of 95 */

Comment style, trailing whitespace ... please run at least some kind of
checkpatch yourself.

johannes