Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1935169rwl; Thu, 30 Mar 2023 03:45:51 -0700 (PDT) X-Google-Smtp-Source: AKy350ZIFHu2Jn8mxikJrQYlw4wYk4FsXIHn2fUXD2bysTN6XenHJQ6ZTvHSbLZWmBT1GuyydEHS X-Received: by 2002:a62:7988:0:b0:625:e8ec:4f5b with SMTP id u130-20020a627988000000b00625e8ec4f5bmr22449054pfc.6.1680173151751; Thu, 30 Mar 2023 03:45:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680173151; cv=none; d=google.com; s=arc-20160816; b=ZVWOeFikmCtga57LA/fBE7PXBirnOvUhccTmw797Ib8k0JTKA81d5f2+0QStgR9fCQ H1Z/O6I1LKgPU8Dg8WGCI8ZXEnBnTLVs1ZFqJwX4tyao4jWr+LQ+OgA7j6l19Kfw+bsG MzL101OVMiS20BgHOBWKKyDJRK/cmxC0B21r4I+dLiUmhQMukv2LGj6b3hJNnRqlDvY/ gLlRQ1ArdtUbkrGvhL+Dev38pKpr/wSFgbojOMFvg0xCE0fS/owZsb8gdMrSoguFm9cB FqgDswn78NEtrFfWxg1mAPC/pQRDNRa0oL1AMK6qaU0kErQkR4908+vNXFsuGKc8sp9Z NXug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id:dkim-signature; bh=UBehT8pNiRhv/K+Pe28HQBR49fVVeAMH3P8J/KS4aE4=; b=I+ynV20Pb/V5Vs0e/SYsnqxfbeFwOGlX8xYFtLgfqbJtn42wen+s6pUmR19cbmGGwh SA2r+/KATUr4TcAWFYJQVMgqrtz6FGFooqpiKjapIyy+AUS5mb/ys3fDoRbHYdX/2MxU KDF6Bh+RrTkGQvlQ7GBdzy4rJ9PQ9lqkxZuMo8fKCodndsQH4u0XW2L00Gafr8l5Cm7d VFXWNN5nD1JvwVehgyeWwMpsjRW332ref3Hf2WLMgWH/9TdkCOm1FXlz8+Va3DbEIQpd ByNd/J/V4YAvBLZxVkLzTVICUTiEsLowM0QDJOQ9J0IwvTBUzTVpMFbdsi+1e6UA5Rjx 95mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=aGTToQjb; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x26-20020a63171a000000b00502d6f14309si33790531pgl.809.2023.03.30.03.45.44; Thu, 30 Mar 2023 03:45:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=aGTToQjb; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230512AbjC3Ko7 (ORCPT + 59 others); Thu, 30 Mar 2023 06:44:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbjC3Ko3 (ORCPT ); Thu, 30 Mar 2023 06:44:29 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68FC286A9 for ; Thu, 30 Mar 2023 03:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=UBehT8pNiRhv/K+Pe28HQBR49fVVeAMH3P8J/KS4aE4=; t=1680173048; x=1681382648; b=aGTToQjbrcGhtr3bhWQQgvurZUu3rwwLYHunNvPCTV99+FC qfvPGe2rzkZgKSNW/VCUfTtygNv5SJmJHW+uTC/vOL9JlpdjjFbT2HXydDwxAZ9PprYtibmD06hUQ 342+0B01WjowHKL/jawLwMm2l6++wSkIQ+kBqzJyqkPJJFqf2Z5mHf/Uh/vOsRikNJLLiUIxF7o0s GRS3O/Sb5qj7Xt/ANd119LnO97TZ7chHF2xkoXQIsjYlM9AU4PO/SyHjrqoCUq1L4dEMAqTCjVfhn xVj9qf63BWT6Xaj90GIeyYAHl59jo6VGISGtDMMNNY4AtZmgyGpgWlUB1Jd9Ce9w==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1phplF-000zbi-21; Thu, 30 Mar 2023 12:44:05 +0200 Message-ID: Subject: Re: [PATCH] wifi: cfg80211: beacon EHT rate support From: Johannes Berg To: Aloka Dixit , linux-wireless@vger.kernel.org Date: Thu, 30 Mar 2023 12:44:04 +0200 In-Reply-To: <20230329000902.17992-1-quic_alokad@quicinc.com> References: <20230329000902.17992-1-quic_alokad@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2023-03-28 at 17:09 -0700, Aloka Dixit wrote: > + switch (wdev->iftype) { > + case NL80211_IFTYPE_AP: > + width =3D wdev->u.ap.preset_chandef.width; This seems a bit awkward and annoying, it means that we have to keep using the API that sets the preset_chandef first, and it also means it won't work for multi-link. Couldn't you link it with the config in start_ap/join_mesh? And per-link config in set_tx_bitrate_mask()? Also not sure about this at all in parse_tid_conf()? johannes