Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <312f1476-b78b-b7f0-26f9-512a7dc2b6b7@quicinc.com>
Date:   Thu, 30 Mar 2023 15:40:18 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] wifi: cfg80211: beacon EHT rate support
To:     Johannes Berg <johannes@sipsolutions.net>,
        <linux-wireless@vger.kernel.org>
References: <20230329000902.17992-1-quic_alokad@quicinc.com>
 <d54800ae88be1eb232df7794e741dfc304c3ee9a.camel@sipsolutions.net>
Content-Language: en-US
From:   Aloka Dixit <quic_alokad@quicinc.com>
In-Reply-To: <d54800ae88be1eb232df7794e741dfc304c3ee9a.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/30/2023 3:44 AM, Johannes Berg wrote:
> On Tue, 2023-03-28 at 17:09 -0700, Aloka Dixit wrote:
> 
>> +		switch (wdev->iftype) {
>> +		case NL80211_IFTYPE_AP:
>> +			width = wdev->u.ap.preset_chandef.width;
> 
> This seems a bit awkward and annoying, it means that we have to keep
> using the API that sets the preset_chandef first, and it also means it
> won't work for multi-link.
> 

Okay, I can do it the same with it is done in he_get_txmcsmap():
	chandef = wdev_chandef(wdev, link_id);

> Couldn't you link it with the config in start_ap/join_mesh? And per-link
> config in set_tx_bitrate_mask()?
> 

Please correct me if I'm wrong but ieee80211_set_bitrate_mask() need not 
be changed for setting the beacon rate in non-MLO case, right?
Because it does not have anything related to he_mcs currently too.

> Also not sure about this at all in parse_tid_conf()?
> 

Can you please explain this point.

I didn't find existing HWSIM support for this feature so I mainly tested 
manually - setting the beacon rate in hostapd and checking that the mask 
generated in nl80211.c is valid.

Thanks.