Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1188360rwl; Fri, 31 Mar 2023 07:50:24 -0700 (PDT) X-Google-Smtp-Source: AKy350YEHljRwGJSICxfOI6Byaauydjq2hFICpOYVhDdI6rBNAybPA6P7zo/7UReJP0fwCH6hACY X-Received: by 2002:a17:906:148d:b0:8b1:7e23:5041 with SMTP id x13-20020a170906148d00b008b17e235041mr25819922ejc.39.1680274224350; Fri, 31 Mar 2023 07:50:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680274224; cv=none; d=google.com; s=arc-20160816; b=m6obRMXtXFCFcDABAg8GWjAF1de+zCmWOlYFswQoocwPm16VEVs9uD8av6Qe7yYFP1 CfnHLztgrReC0d74eOVSGREmR3WJKo+MDmM9q4bDfgdN5aJJctsnYpfbSi7Ae7i00LJ3 gsuqDBsUgxOypajTgyD0HNofjXqacVKVnceIhpO42zS3i3WQy+SWwQd+xYjiPnwI8L/A AOGIJZu+KMXi7yGa3e4FCVKFlYS70/LvollHsPS/jU40Bbim9CaTBvjhLjXFeqoZK3aJ sIxGFrJ/tgI1ZJzpgigL6/O0UNuY/P+5EbxF6yiqZ7BmI4zlU6vaaFSfSlpvo0bDRm20 G2tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=AgDipALkGNqNs/sUs2A9PU4o8plN9rq5ohrYn182ZNs=; b=0IgS2v2SgmIXEfGUXN2FHvbSPtBzK2zNh4tQ2+UO5k8TdiA6qgRTV6khKTdfZ+kGkq hpph5VmbFO/dpnncrLmDWGdmMO98RCi6fBQXwelAXMksiWMOmdageQdF8pV7XOLHb2HG bnNbzw9olCSRtsoHFN0Pq9vJ4goUs4rTh38L63hps82X+WQWrlRRVQDJG7QAK4ngW1+P IwFrw7sQNR4RKvHl1GOAbj7joQgQHrGUPjcWL3zRrAucqfsE/c52Zu8B9vjdIGfZzCkm 6jLKobcMwg90hW8e7jVuH/e/yXSxDRZMHQP36zdsAbZPW0YNkLeKt7ATJVeN/lqmqg6o wI5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L457bPwN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w12-20020aa7dccc000000b0050202f2d6a7si2142834edu.319.2023.03.31.07.50.10; Fri, 31 Mar 2023 07:50:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L457bPwN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232885AbjCaOqa (ORCPT + 58 others); Fri, 31 Mar 2023 10:46:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232086AbjCaOq0 (ORCPT ); Fri, 31 Mar 2023 10:46:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04FA42031B; Fri, 31 Mar 2023 07:46:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 93E6A629C6; Fri, 31 Mar 2023 14:46:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60811C4339B; Fri, 31 Mar 2023 14:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680273979; bh=teWUDEWRNjOrCokuMkC7iMtqqgjV3KHiiJPzrW2yqoo=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=L457bPwNtr2YNzRK2HvoBzV05ESkOo/S+oq8r9GbEonbmV+2uIl5kFRcm0faje5er bEO+2DJ40eK/kQrT8K4WZZdKcQAly0+dXsNqzSEtkfvENLUBtYzuM8vjL1+dwRvR5f zGDpkQzyNhkJRaZQOep/X9kwYLjy2KUfyiX4aA0XYkc2r8knZPf1CMPqS8ZkY7aNWi SQQatA9A+6x6WB6Tkgw1jeQoVSFwgGRjKOcPwnw82LK5H5e59OQXquKlVm0oAjqRyU ypMwXkC31WhlM0C0qigg8ipieLmOOPCHybg/7CZbmPUwdX8AKwq36mnJOTkIvwBHfo fkt406DwAcxYw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw88: remove unused rtw_pci_get_tx_desc function From: Kalle Valo In-Reply-To: <20230320233448.1729899-1-trix@redhat.com> References: <20230320233448.1729899-1-trix@redhat.com> To: Tom Rix Cc: tony0620emma@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, nathan@kernel.org, ndesaulniers@google.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168027397456.32751.13158951931785484475.kvalo@kernel.org> Date: Fri, 31 Mar 2023 14:46:16 +0000 (UTC) X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Tom Rix wrote: > clang with W=1 reports > drivers/net/wireless/realtek/rtw88/pci.c:92:21: error: > unused function 'rtw_pci_get_tx_desc' [-Werror,-Wunused-function] > static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx) > ^ > This function is not used, so remove it. > > Signed-off-by: Tom Rix > Reviewed-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. c9b6111a6f94 wifi: rtw88: remove unused rtw_pci_get_tx_desc function -- https://patchwork.kernel.org/project/linux-wireless/patch/20230320233448.1729899-1-trix@redhat.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches